From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/4] maple: match "pcie" name for CPC945
Date: Wed, 13 Dec 2006 09:26:46 +1100 [thread overview]
Message-ID: <1165962406.11914.87.camel@localhost.localdomain> (raw)
In-Reply-To: <20061211223812.GD6573@localdomain>
On Mon, 2006-12-11 at 16:38 -0600, Nathan Lynch wrote:
> Segher Boessenkool wrote:
> > >Some firmwares have "pcie" for the "name" property of the CPC945 PCI
> > >Express host bridge. Check for "pcie" in addition to "pci" so we
> > >don't miss it.
> >
> > You shouldn't use "name" but "device_type" and "compatible".
>
> Like this?
>
> (Hmm, does the u3-agp on maple have "pci" for device_type?)
I hope so...
There are plenty bits of code in the kernel that _assume_ that
device_type is PCI for PHB's and P2P bridges, wether they are PCI, PCI-X
or PCIe. prom_parse.c is one, but there is more.
Ben.
prev parent reply other threads:[~2006-12-12 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 0:50 [PATCH 1/4] maple: match "pcie" name for CPC945 Nathan Lynch
2006-12-07 0:50 ` [PATCH 2/4] maple: select PPC_RTAS Nathan Lynch
2006-12-07 0:50 ` [PATCH 3/4] add rtas_service_present() helper Nathan Lynch
2006-12-07 0:50 ` [PATCH 4/4] maple: use RTAS for reboot and halt Nathan Lynch
2006-12-07 2:51 ` [PATCH 3/4] add rtas_service_present() helper Michael Ellerman
2006-12-07 3:25 ` Nathan Lynch
2006-12-07 21:05 ` Linas Vepstas
2006-12-07 3:20 ` [PATCH 1/4] maple: match "pcie" name for CPC945 Olof Johansson
2006-12-07 8:41 ` Segher Boessenkool
2006-12-07 8:30 ` Segher Boessenkool
2006-12-11 22:38 ` Nathan Lynch
2006-12-12 22:26 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165962406.11914.87.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).