From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id DDB3F679E0 for ; Wed, 13 Dec 2006 14:54:55 +1100 (EST) Subject: Re: [PATCH] drivers/net: spidernet driver on Celleb From: Benjamin Herrenschmidt To: Linas Vepstas In-Reply-To: <20061213011435.GN4329@austin.ibm.com> References: <200612120525.kBC5PpWC009418@toshiba.co.jp> <20061213011435.GN4329@austin.ibm.com> Content-Type: text/plain Date: Wed, 13 Dec 2006 14:54:37 +1100 Message-Id: <1165982077.11914.123.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, jim@jklewis.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2006-12-12 at 19:14 -0600, Linas Vepstas wrote: > On Tue, Dec 12, 2006 at 02:25:50PM +0900, Ishizaki Kou wrote: > > > > Following are the changes. > > -This patch enables auto-negotiation. > > -Loading firmware is done when spidernet_open() is called. > > -And this patch adds other several small changes for Celleb. > > -This patch is not tested on CellBlade. > > I just tested this, and it does not work. Jim Lewis is gone > until the new year. However, as he was leaving, he grumbled something > about how autonegotiation simply won't work on the spider. > (I didn't think to ask about the details). Perhaps he'll > look at his email soon? Duh ? Autoneg is completely local to the PHY. It will not work on the Cell blade because it's using a fiber link though, thus we probably need to disable this code when running on a fiber link. > I've been trying to figure out how to modify the patch to make it > work anyway, but so far, no success. > > Basically, in genmii_poll_link(), > status = phy_read(phy, MII_BMSR); > status & BMSR_LSTATUS will always be zero. > > So I tried ignoring this value, and calling setup_forced() > However, this still doesn't get the thing working. > I am somewhat at a loss to see why right now, since > I don't see what may be causing this. I can have a look, most of the code was borrowed from sungem and I wrote the MII code for it :-) Ben.