From: Jim Lewis <jim@jklewis.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net: spidernet driver on Celleb
Date: Wed, 13 Dec 2006 00:30:35 -0600 [thread overview]
Message-ID: <1165991435.21877.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1165982077.11914.123.camel@localhost.localdomain>
I got a note from Jens earlier today that mentioned some changes he has
made to the PHY code. He plans to get those in soon, so this might be
solved already.
Jim Lewis
On Wed, 2006-12-13 at 14:54 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2006-12-12 at 19:14 -0600, Linas Vepstas wrote:
> > On Tue, Dec 12, 2006 at 02:25:50PM +0900, Ishizaki Kou wrote:
> > >
> > > Following are the changes.
> > > -This patch enables auto-negotiation.
> > > -Loading firmware is done when spidernet_open() is called.
> > > -And this patch adds other several small changes for Celleb.
> > > -This patch is not tested on CellBlade.
> >
> > I just tested this, and it does not work. Jim Lewis is gone
> > until the new year. However, as he was leaving, he grumbled something
> > about how autonegotiation simply won't work on the spider.
> > (I didn't think to ask about the details). Perhaps he'll
> > look at his email soon?
>
> Duh ? Autoneg is completely local to the PHY. It will not work on the
> Cell blade because it's using a fiber link though, thus we probably need
> to disable this code when running on a fiber link.
>
> > I've been trying to figure out how to modify the patch to make it
> > work anyway, but so far, no success.
> >
> > Basically, in genmii_poll_link(),
> > status = phy_read(phy, MII_BMSR);
> > status & BMSR_LSTATUS will always be zero.
> >
> > So I tried ignoring this value, and calling setup_forced()
> > However, this still doesn't get the thing working.
> > I am somewhat at a loss to see why right now, since
> > I don't see what may be causing this.
>
> I can have a look, most of the code was borrowed from sungem and I wrote
> the MII code for it :-)
>
> Ben.
>
next prev parent reply other threads:[~2006-12-13 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 5:25 [PATCH] drivers/net: spidernet driver on Celleb Ishizaki Kou
2006-12-12 12:24 ` Christoph Hellwig
2006-12-14 11:02 ` Ishizaki Kou
2006-12-13 1:14 ` Linas Vepstas
2006-12-13 3:54 ` Benjamin Herrenschmidt
2006-12-13 6:30 ` Jim Lewis [this message]
2006-12-13 9:03 ` Jens Osterkamp
2006-12-13 16:52 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165991435.21877.3.camel@localhost.localdomain \
--to=jim@jklewis.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).