linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: Olof Johansson <olof@lixom.net>,
	linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 6/9] MPIC MSI allocator
Date: Thu, 14 Dec 2006 12:02:28 +1100	[thread overview]
Message-ID: <1166058148.11914.255.camel@localhost.localdomain> (raw)
In-Reply-To: <1166057940.6838.25.camel@concordia.ozlabs.ibm.com>


> if get_property("msi_available")
> 	mpic_msi_reserve_dt_irqs()

available-msi is a better name now that I think of it, or better even:
"msi-ranges"

> elif is_u3_or_u4()
> 	mpic_msi_reserve_u3u4_irqs()
> else
> 	return error
> 
> Because if we don't have a firmware property, and we don't make an
> educated guess at what's reserved, then there's a very good chance our
> first MSI will get hwirq 0 and that it won't work.
> 
> As far as putting hacks in the MPIC driver .. have you read it
> lately? ;)  But seriously, I think if there's anyway these magic numbers
> should be, it is in this code, not the platform code.

Ben.

  reply	other threads:[~2006-12-14  1:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-13 10:39 [PATCH 0/9] Powerpc MSI Implementation (.. again) Michael Ellerman
2006-12-13 10:39 ` [PATCH 1/9] Add #defines for Hypertransport MSI fields Michael Ellerman
2006-12-13 10:39 ` [PATCH 2/9] Rip out the existing powerpc msi stubs Michael Ellerman
2006-12-13 10:39 ` [PATCH 3/9] Powerpc MSI implementation Michael Ellerman
2006-12-13 10:39 ` [PATCH 4/9] Enable MSI on Powerpc Michael Ellerman
2006-12-13 10:39 ` [PATCH 5/9] RTAS MSI implementation Michael Ellerman
2006-12-13 10:40 ` [PATCH 6/9] MPIC MSI allocator Michael Ellerman
2006-12-13 18:23   ` Olof Johansson
2006-12-13 23:25     ` Benjamin Herrenschmidt
2006-12-14  0:09       ` Olof Johansson
2006-12-14  0:32         ` Benjamin Herrenschmidt
2006-12-14  0:59           ` Michael Ellerman
2006-12-14  1:02             ` Benjamin Herrenschmidt [this message]
2006-12-14  1:06               ` Michael Ellerman
2006-12-14 14:46                 ` Segher Boessenkool
2006-12-14 19:44                   ` Benjamin Herrenschmidt
2006-12-15  1:47                     ` Segher Boessenkool
2006-12-15  1:51                       ` Michael Ellerman
2006-12-15  2:28                       ` Benjamin Herrenschmidt
2006-12-15  2:58                         ` Segher Boessenkool
2006-12-15  6:42                           ` Olof Johansson
2006-12-14  1:06             ` Olof Johansson
2006-12-14  0:34     ` Michael Ellerman
2006-12-13 10:40 ` [PATCH 7/9] MPIC MSI backend Michael Ellerman
2006-12-13 10:40 ` [PATCH 9/9] Enable MSI mappings for MPIC Michael Ellerman
2006-12-13 10:40 ` [PATCH 8/9] Activate MSI on Powerpc Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1166058148.11914.255.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).