From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 6/19] powerpc: avoid claiming some PCI bus
Date: Thu, 14 Dec 2006 15:55:15 +1100 [thread overview]
Message-ID: <1166072115.11914.280.camel@localhost.localdomain> (raw)
In-Reply-To: <200612140228.kBE2SvUQ013034@toshiba.co.jp>
On Thu, 2006-12-14 at 11:28 +0900, Ishizaki Kou wrote:
> Celleb has multiple PCI buses. Devices on some of those PCI buses
> require to assign resources by Linux. This patch is for such buses
> not to claim resources, because claimed resource does not become a
> target for resource assign.
I don't fully understand what's going on here, and why you have this
insert_resource() hacks in the platform PCI code as well...
Care to explain ? Unfortunately, we haven't received the HW yet so I
can't have a look by myself and propose alternate patches just yet...
Cheers,
Ben.
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> ---
>
> Index: linux-powerpc-git/arch/powerpc/kernel/pci_64.c
> diff -u linux-powerpc-git/arch/powerpc/kernel/pci_64.c:1.1.1.1 linux-powerpc-git/arch/powerpc/kernel/pci_64.c:1.3
> --- linux-powerpc-git/arch/powerpc/kernel/pci_64.c:1.1.1.1 Wed Dec 6 08:25:43 2006
> +++ linux-powerpc-git/arch/powerpc/kernel/pci_64.c Tue Dec 12 15:37:56 2006
> @@ -249,8 +249,13 @@
> if (firmware_has_feature(FW_FEATURE_ISERIES))
> return;
>
> - list_for_each_entry(b, &pci_root_buses, node)
> - pcibios_claim_one_bus(b);
> + list_for_each_entry(b, &pci_root_buses, node) {
> + if (machine_is(celleb) &&
> + ppc_md.pci_probe_mode(b) != PCI_PROBE_DEVTREE)
> + ;
> + else
> + pcibios_claim_one_bus(b);
> + }
> }
>
> static u32 get_int_prop(struct device_node *np, const char *name, u32 def)
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2006-12-14 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 2:28 [PATCH 6/19] powerpc: avoid claiming some PCI bus Ishizaki Kou
2006-12-14 4:55 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166072115.11914.280.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).