From: Michal Ostrowski <mostrows@watson.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Avoid calling get_irq_server() with a real, not virtual irq.
Date: Thu, 14 Dec 2006 06:46:16 -0600 [thread overview]
Message-ID: <1166100376.5438.59.camel@kdsk1.austin.ibm.com> (raw)
In-Reply-To: <1166074809.11914.315.camel@localhost.localdomain>
If you set the priority level to 0xff, you've disabled the interrupt:
the XICS model prohibits it from being delivered.
On the other hand, calling get_irq_server() is obviously wrong.
xics_remap_irq() calls xics_mask_real_irq() in the case that it was not
able to convert real->virt. That being the case, how can we expect
xics_mask_real_irq to be able to do so in order to call
get_irq_server()?
--
Michal Ostrowski <mostrows@watson.ibm.com>
On Thu, 2006-12-14 at 16:40 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2006-12-13 at 22:35 -0600, Michal Ostrowski wrote:
>
> > We can use default_server when masking an interrupt vector.
>
> Is that guaranteed by PAPR ?
>
> Ben.
>
>
prev parent reply other threads:[~2006-12-14 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 4:35 [PATCH] Avoid calling get_irq_server() with a real, not virtual irq Michal Ostrowski
2006-12-14 5:40 ` Benjamin Herrenschmidt
2006-12-14 12:46 ` Michal Ostrowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166100376.5438.59.camel@kdsk1.austin.ibm.com \
--to=mostrows@watson.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).