From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: consolidate mpc83xx platform files
Date: Tue, 19 Dec 2006 08:19:14 +1100 [thread overview]
Message-ID: <1166476754.19254.9.camel@localhost.localdomain> (raw)
In-Reply-To: <B38E3DDE-A18F-4319-A968-B0C22C001391@kernel.crashing.org>
> > +#if defined(CONFIG_I2C_MPC) && defined(CONFIG_SENSORS_DS1374)
> > +extern ulong ds1374_get_rtc_time(void);
> > +extern int ds1374_set_rtc_time(ulong);
> > +
> > +static int __init mpc83xx_rtc_hookup(void)
> > +{
> > + struct timespec tv;
> > +
> > + ppc_md.get_rtc_time = ds1374_get_rtc_time;
> > + ppc_md.set_rtc_time = ds1374_set_rtc_time;
> > +
> > + tv.tv_nsec = 0;
> > + tv.tv_sec = (ppc_md.get_rtc_time) ();
> > + do_settimeofday(&tv);
> > +
> > + return 0;
> > +}
> > +
> > +late_initcall(mpc83xx_rtc_hookup);
> > +#endif
>
> This is sort of evil and we need to clean it up, but we have some
> time for 2.6.21. Does the MPC832x MDS have the DS1374?
Also, always test if (machine_is(xxx)) in your initcalls since they'll
be called regardless of what machine has been selected.
Ben.
next prev parent reply other threads:[~2006-12-18 21:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 1:04 [PATCH] powerpc: consolidate mpc83xx platform files Kim Phillips
2006-12-15 16:09 ` Kumar Gala
2006-12-15 17:23 ` Dan Malek
2006-12-18 21:22 ` Benjamin Herrenschmidt
2006-12-15 17:59 ` Olof Johansson
2006-12-16 1:31 ` Stephen Rothwell
2006-12-18 21:23 ` Benjamin Herrenschmidt
2006-12-18 21:19 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-19 21:30 Kim Phillips
2006-12-19 22:19 ` Ben Warren
2006-12-18 14:44 Joakim Tjernlund
2006-12-18 16:51 ` Olof Johansson
2006-12-12 17:36 Kim Phillips
2006-12-12 18:03 ` Kumar Gala
2006-12-09 1:07 Kim Phillips
2006-12-09 7:14 ` Benjamin Herrenschmidt
2006-12-11 3:41 ` Kumar Gala
2006-12-11 21:51 ` Kim Phillips
2006-12-11 22:08 ` Kumar Gala
2006-12-12 2:10 ` Kim Phillips
2006-12-12 2:29 ` Benjamin Herrenschmidt
2006-12-12 2:31 ` Kumar Gala
2006-12-12 21:30 ` Scott Wood
2006-12-12 21:47 ` Benjamin Herrenschmidt
2006-12-12 22:06 ` Kumar Gala
2006-12-12 22:24 ` Kim Phillips
2006-12-12 22:28 ` Kumar Gala
2006-12-12 22:38 ` Kim Phillips
2006-12-12 22:44 ` Benjamin Herrenschmidt
2006-12-12 22:51 ` Kim Phillips
2006-12-12 22:40 ` Scott Wood
2006-12-13 0:23 ` Kumar Gala
2006-12-13 5:25 ` Geoff Thorpe
2006-12-13 6:07 ` Kumar Gala
2006-12-13 17:48 ` Geoff Thorpe
2006-12-13 18:21 ` Kim Phillips
2006-12-13 21:13 ` Dan Malek
2006-12-12 22:03 ` Kumar Gala
2006-12-12 22:41 ` Scott Wood
2006-12-12 22:46 ` Benjamin Herrenschmidt
2006-12-13 0:20 ` Kumar Gala
2006-12-18 5:17 ` Paul Mackerras
2006-12-18 17:04 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166476754.19254.9.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).