From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs
Date: Wed, 20 Dec 2006 10:40:28 +1100 [thread overview]
Message-ID: <1166571629.19254.90.camel@localhost.localdomain> (raw)
In-Reply-To: <20061219172202.29ef9b1d.kim.phillips@freescale.com>
> it's not characteristic of FSL _boards_ per se. It's characteristic of FSL
> powerpc SoC chips, and it resides in a file that will only be built for that
> case. This is a legitimate way to support multiple platforms in a single
> image without incurring multiple device_initcall()s with the same parameter.
> I didn't see an appropriate ppc_md. function to use; are you suggesting we add
> one just for this? wouldn't that be fsl specific also, but reside in common code?
What cores do those chip use ? Any reason why one couldn't build a
kernel that boots those chips -and- chrp,pmac,etc... in one image ?
If that is the case, then your initcall will incorrectly be called on
platforms that don't need it.
I think what we need to do is to define a mecanism for board initcalls.
Something like board_xxx_initcall(boardname, function);
Ben.
next prev parent reply other threads:[~2006-12-19 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 21:31 [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs Kim Phillips
2006-12-19 23:00 ` Benjamin Herrenschmidt
2006-12-19 23:22 ` Kim Phillips
2006-12-19 23:40 ` Benjamin Herrenschmidt [this message]
2006-12-20 0:10 ` Scott Wood
2006-12-20 0:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166571629.19254.90.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=kim.phillips@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).