Re: [PATCH] Fix Maple PATA IRQ assignment.

[David Woodhouse <dwmw2@infradead.org>]

On Mon, 2007-01-01 at 21:34 +0000, Alan wrote:
> > Er, that would be pci_get_legacy_ide_irq(), which is what I _have_ used.
> 
> Ok un-NAK that, I didn't realise there was a wrapper to those methods too.
> 
> > As I said, the Maple board is the _only_ user, across all architectures
> > and all PowerPC platforms, of pci_get_legacy_ide_irq(). And the AMD74xx
> 
> The Motorola's also used to use funny IRQ numbers for IDE legacy - or are
> they no longer supported

Well, there's no other implementation of pci_get_legacy_ide_irq() (other
than the default {15,14}) except for Maple, throughout all of arch/ppc
and arch/powerpc.

> > driver is the only driver which calls it -- for Maple. Hence the
> > suggestion that perhaps there's a better way to do it.
> 
> IRQ routing is platform not driver. Let's keep it that way.

Well, yes -- that's what my patch does. I was just thinking that since
this is the _only_ platform which currently uses it, it might be worth
fixing it differently -- by changing the platform setup code to either
route the interrupts to match what the generic code expects, or switch
the controller to native mode.

I'm happy enough with the patch I sent too though.

-- 
dwmw2