[PATCH] sound: aoa of_node_put and kfree cleanup

[PATCH] sound: aoa of_node_put and kfree cleanup

[Mariusz Kozlowski]

Hello,

	This patch removes redundant argument checks for of_node_put() and kfree().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

 sound/aoa/fabrics/snd-aoa-fabric-layout.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
--- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2006-12-28 12:57:54.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2007-01-02 01:50:26.000000000 +0100
@@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
 	list_del(&ldev->list);
 	layouts_list_items--;
  outnodev:
- 	if (sound) of_node_put(sound);
+ 	of_node_put(sound);
  	layout_device = NULL;
- 	if (ldev) kfree(ldev);
+ 	kfree(ldev);
 	return -ENODEV;
 }
 


-- 
Regards,

	Mariusz Kozlowski

Re: [PATCH] sound: aoa of_node_put and kfree cleanup

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Tue, 2007-01-02 at 13:50 +0100, Mariusz Kozlowski wrote:

> 	This patch removes redundant argument checks for of_node_put() and kfree().

Looks good to me, thanks.

> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

>  sound/aoa/fabrics/snd-aoa-fabric-layout.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
> --- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2006-12-28 12:57:54.000000000 +0100
> +++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2007-01-02 01:50:26.000000000 +0100
> @@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
>  	list_del(&ldev->list);
>  	layouts_list_items--;
>   outnodev:
> - 	if (sound) of_node_put(sound);
> + 	of_node_put(sound);
>   	layout_device = NULL;
> - 	if (ldev) kfree(ldev);
> + 	kfree(ldev);
>  	return -ENODEV;
>  }
>  
> 
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [Alsa-devel] [PATCH] sound: aoa of_node_put and kfree cleanup

[Takashi Iwai]

At Tue, 2 Jan 2007 13:50:57 +0100,
Mariusz Kozlowski wrote:
> 
> Hello,
> 
> 	This patch removes redundant argument checks for of_node_put() and kfree().
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> 
>  sound/aoa/fabrics/snd-aoa-fabric-layout.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Merged to ALSA tree now.  Thanks.


Takashi

> 
> diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
> --- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2006-12-28 12:57:54.000000000 +0100
> +++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2007-01-02 01:50:26.000000000 +0100
> @@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
>  	list_del(&ldev->list);
>  	layouts_list_items--;
>   outnodev:
> - 	if (sound) of_node_put(sound);
> + 	of_node_put(sound);
>   	layout_device = NULL;
> - 	if (ldev) kfree(ldev);
> + 	kfree(ldev);
>  	return -ENODEV;
>  }
>  
> 
> 
> -- 
> Regards,
> 
> 	Mariusz Kozlowski
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
>