From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix irq routing on some PowerMac 32 bits
Date: 10 Jan 2007 11:00:03 +0800 [thread overview]
Message-ID: <1168398002.571.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1165806548.7260.0.camel@localhost.localdomain>
Ben,
After apply your patch, my 8548CDS board blocked when booting up.
Should I adjust my flat device tree or bug introduced by this patch?
Thanks.
Roy
On Mon, 2006-12-11 at 11:09, Benjamin Herrenschmidt wrote:
> The changes to use pci_read_irq_line() broke interrupt parsing
> on some 32 bits powermacs (oops). The reason is a bit obscure.
> The code to parse interrupts happens earlier now, during
> pcibios_fixup() as the PCI bus is being probed. However, the
> current implementation pci_device_to_OF_node() for 32 bits
> powerpc relies, on machines like PowerMac who renumber PCI busses,
> on a table called pci_OF_bus_map containing a map of bus numbers
> between the kernel and the firmware which is setup only later.
> Thus, it fails to match the device node. In addition, some of
> Apple internal PCI devices lack a proper PCI_INTERRUPT_PIN, thus
> preventing the fallback mapping code to work.
>
> This patch fixes it by making pci_device_to_OF_node() 32 bits
> implementation use a different algorithm that works without
> using the pci_OF_bus_map thing (which I intend to deprecate
> anyway). It's a bit slower but that function isn't called in
> any hot path hopefully.
>
next prev parent reply other threads:[~2007-01-10 2:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 3:09 [PATCH] powerpc: Fix irq routing on some PowerMac 32 bits Benjamin Herrenschmidt
2006-12-11 6:22 ` Paul Collins
2006-12-11 6:40 ` Benjamin Herrenschmidt
2007-01-10 3:00 ` Zang Roy-r61911 [this message]
2007-01-10 3:16 ` Benjamin Herrenschmidt
2007-01-10 3:34 ` Zang Roy-r61911
2007-01-10 3:58 ` Benjamin Herrenschmidt
2007-01-10 8:57 ` Zang Roy-r61911
2007-01-10 12:13 ` Benjamin Herrenschmidt
2007-01-10 12:22 ` Segher Boessenkool
2007-01-11 5:29 ` Zang Roy-r61911
2007-01-10 17:42 ` Wang Haiying-r54964
2007-01-11 5:25 ` Zang Roy-r61911
2007-01-11 5:28 ` Benjamin Herrenschmidt
2007-01-11 5:36 ` Zang Roy-r61911
2007-01-11 5:40 ` Benjamin Herrenschmidt
2007-01-11 5:58 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168398002.571.3.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).