From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: Linux PPC DEV <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA
Date: Thu, 11 Jan 2007 13:56:53 +1100 [thread overview]
Message-ID: <1168484213.22458.386.camel@localhost.localdomain> (raw)
In-Reply-To: <45A410F0.3090503@246tNt.com>
On Tue, 2007-01-09 at 23:02 +0100, Sylvain Munaut wrote:
> About the serial patch :
>
> > I didn't put this one in for 2.6.20, because it doesn't solve any
> > actual problem, and Ben H tells me it might trigger a bug in the
> > generic irq code.
>
> The bug it triggered has been fixed eons ago (like last December 22),
> in a impressive one-liner patch that has 5 Signed-off/Acked-by ;) ...
>
> But that code is rarely executed as it would imply the PSC can be
> unloaded ... (impossible when used as console). So later merge
> is OK.
And there is no real problem in this case for not disposing of the
mapping anyway. You'll just get the same mapping again when you reload
it.
Ben.
next prev parent reply other threads:[~2007-01-11 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 22:29 [PATCH 0/4] 52xx fixes for 2.6.20 Sylvain Munaut
2007-01-02 22:29 ` [PATCH 1/4] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Sylvain Munaut
2007-01-02 22:29 ` [PATCH 2/4] powerpc: 52xx, Don't use device_initcall to probe of_platform_bus Sylvain Munaut
2007-01-02 22:29 ` [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA Sylvain Munaut
2007-01-02 22:29 ` [PATCH 4/4] powerpc: Restore 'proper' link order in platform Sylvain Munaut
2007-01-02 22:51 ` Grant Likely
2007-01-02 22:53 ` [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA Grant Likely
2007-01-09 12:08 ` Paul Mackerras
2007-01-09 22:02 ` Sylvain Munaut
2007-01-11 2:56 ` Benjamin Herrenschmidt [this message]
2007-01-02 22:52 ` [PATCH 2/4] powerpc: 52xx, Don't use device_initcall to probe of_platform_bus Grant Likely
2007-01-02 22:51 ` [PATCH 1/4] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Grant Likely
2007-01-09 12:05 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168484213.22458.386.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox