From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: linux-ide@vger.kernel.org, paulus@samba.org,
Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] drivers/ata: export some static functions in libata-core.c
Date: Fri, 12 Jan 2007 08:37:12 +1100 [thread overview]
Message-ID: <1168551432.22458.421.camel@localhost.localdomain> (raw)
In-Reply-To: <200701110928.l0B9SUUv028654@toshiba.co.jp>
On Thu, 2007-01-11 at 18:30 +0900, Akira Iguchi wrote:
> Hi, Arnd-san.
>
> Thank you for checking our patches.
>
> >On Thursday 11 January 2007 09:56, Akira Iguchi wrote:
> >> This patch modifies some static functions in libata-core.c
> >> and libata.h to use them in ata_scc.c.
> >
> >Exporting new symbols needs some explanation here about why they
> >should now be global for ata_scc while the existing drivers
> >did not need them. Since the patch otherwise only moves stuff
> >around as needed, I assume it's good.
>
> I thought it was better to use common functions as far as possible.
> But if it is preferable to copy them in ata_scc.c, I will do so.
Nah, it's not preferable. I think what is preferable on the contrary is
to make even more common function generic enough so you can use them
instead of copying them.
Ben.
next prev parent reply other threads:[~2007-01-11 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701110853.l0B8rtGK009404@toshiba.co.jp>
2007-01-11 9:08 ` [PATCH 2/2] drivers/ata: export some static functions in libata-core.c Arnd Bergmann
2007-01-11 9:30 ` Akira Iguchi
2007-01-11 13:05 ` Arnd Bergmann
2007-01-11 17:17 ` Linas Vepstas
2007-01-12 0:48 ` Akira Iguchi
2007-01-12 0:55 ` Benjamin Herrenschmidt
[not found] ` <200701110928.l0B9SUUv028654@toshiba.co.jp>
2007-01-11 21:37 ` Benjamin Herrenschmidt [this message]
2007-01-11 8:56 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168551432.22458.421.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=arnd@arndb.de \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).