From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id A2E53DDDFE for ; Fri, 12 Jan 2007 18:25:12 +1100 (EST) Subject: Re: [PATCH 3/7] Enable MSI on Powerpc From: Benjamin Herrenschmidt To: Christoph Hellwig In-Reply-To: <20070111213708.GC23237@lst.de> References: <1168514716.63474.857278133999.qpush@cradle> <20070111112503.920E6DDEBE@ozlabs.org> <20070111213708.GC23237@lst.de> Content-Type: text/plain Date: Fri, 12 Jan 2007 18:24:59 +1100 Message-Id: <1168586699.5011.2.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Greg Kroah-Hartman , linuxppc-dev@ozlabs.org, Paul Mackerras , Olof Johannsson , linux-pci@atrey.karlin.mff.cuni.cz List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2007-01-11 at 22:37 +0100, Christoph Hellwig wrote: > > -# Build the PCI MSI interrupt support > > +# Build the PCI MSI interrupt support, but not for arch/powerpc > > +ifndef CONFIG_PPC_MERGE > > obj-$(CONFIG_PCI_MSI) += msi.o > > +endif > > This is not very nice. I'd rather prefer this code beeing funnel in > through your higher level code. There are some issues in hooking the existing intel/altix stuff on Michael's infrastructure that I'd rather not even go near for 2.6.21 so I'd prefer if we could just build the new stuff or the old stuff based on config options as a first step... >>From there, we can start working on doing proper new back-ends for the new stuff for intel and altix. Among others, there have been some nasty calls to the MSI stuff by the pci power management code that I'm not sure the new stuff is dealing with just yet (we don't need them yet for the few powerpc machines for which we have backends for now, though we'll have to fix it). I think it's important that we get this code in 2.6.21 and not wait for having all the old stuff ported to it, as it's really getting fairly urgent to get MSI support in, and I'm quite confident having both old and new infrastructures in until intel/altix are ported over shouldn't be a problem. Ben.