From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: Anton Blanchard <anton@samba.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
Date: Mon, 15 Jan 2007 10:07:56 -0600 [thread overview]
Message-ID: <1168877276.11068.14.camel@localhost> (raw)
In-Reply-To: <20070113124638.GA13493@krispykreme>
On Sat, 2007-13-01 at 23:46 +1100, Anton Blanchard wrote:
> Hi,
>
> Just a few suggestions.
>
> > +#define HCALL_MEDIUM or 2,2,2
>
> Doesnt look like this is used.
seconded. that #define is identical to HMT_MEDIUM out of ppc_asm.h. I
notice that HMT_MEDIUM is actually used throughout this patch, so most
of the way there already.
> > +#define HVSC .long 0x44000022
>
> Could you pick this up from the define in include/asm-powerpc instead?
"#include <asm/hvcall.h>" should do it.
>
> > +#define LOAD_CONST64(r, const) \
> > + lis r, ((const)>>48)&0xFFFF; \
> > + ori r, r, ((const)>>32)&0xFFFF; \
> > + rldicr r, r, 32, 31; \
> > + oris r, r, ((const)>>16)&0xFFFF; \
> > + ori r, r, ((const)>>0)&0xFFFF
>
> It doesnt look like this is used either.
>
> Anton
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2007-01-15 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 1:00 [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb Ishizaki Kou
2007-01-13 12:46 ` Anton Blanchard
2007-01-13 15:53 ` Segher Boessenkool
2007-01-13 17:53 ` Geoff Levand
2007-01-13 20:57 ` Segher Boessenkool
2007-01-15 16:07 ` Will Schmidt [this message]
2007-01-16 11:28 ` Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168877276.11068.14.camel@localhost \
--to=will_schmidt@vnet.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).