Re: [PATCH 8/19] powerpc: supporting interrupts for Celleb

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2007-01-12 at 10:01 +0900, Ishizaki Kou wrote:
> This patch creates Celleb platform dependent files to support interrupts.
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
> ---

There might be ways to make this code simpler and possibily even remove
the spinlock, I have to think about it a bit more and maybe test when/if
we get some hardware here.

One thing is, since you need to mask interrupts while handling them,
you might as well use something like the level handler instead of
fasteoi (unless interrupts behave as edge on your HV in which case the
edge handle woudl do the job though it won't mask the same way).

Then you might also be able to use atomic operations rather than
spinlocks for the updates of the various masks.

There is nothing urgent about those change though, that I would consider
more as optimisations, and I need to better understand what your
hypervisor exactly does to be sure about it, so in the meantime,

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>