From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 16/19] powerpc: udbg supports for Celleb
Date: Thu, 18 Jan 2007 11:38:31 +1100 [thread overview]
Message-ID: <1169080711.4965.28.camel@localhost.localdomain> (raw)
In-Reply-To: <200701120116.l0C1GRLg009802@toshiba.co.jp>
> +void __init udbg_init_debug_beat(void)
> +{
> + celleb_vtermno = 0;
> + udbg_putc = udbg_putc_beat;
> + udbg_getc = udbg_getc_beat;
> + udbg_getc_poll = udbg_getc_poll_beat;
> +}
Is celleb_vtermno ever != 0 ? I don't see that happening in your
patch...
If not, I would just remove it and just pass 0 directly :-) Or make it a
constant instead of a variable. Note that early debug is really just
that: optional early debugging which, when enabled, is likely to prevent
booting on any other platform, so only for use with debug builds. If you
ever need another value in here, thus, it's perfectly fine to make it a
Kconfig option that can be set at build time.
Ben.
next prev parent reply other threads:[~2007-01-18 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 1:16 [PATCH 16/19] powerpc: udbg supports for Celleb Ishizaki Kou
2007-01-18 0:38 ` Benjamin Herrenschmidt [this message]
2007-01-18 7:58 ` Ishizaki Kou
-- strict thread matches above, loose matches on Subject: below --
2006-12-14 2:47 Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169080711.4965.28.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).