From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/5] [POWERPC] cpm2: CPM2 interrupt controller fix
Date: Tue, 23 Jan 2007 06:55:37 +1100 [thread overview]
Message-ID: <1169495737.1582.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20070122164316.79569af9@localhost.localdomain>
On Mon, 2007-01-22 at 16:43 +0300, Vitaly Bordug wrote:
> On Mon, 22 Jan 2007 20:57:35 +1100
> Paul Mackerras wrote:
>
> > Vitaly Bordug writes:
> >
> > > This contains important fixes for the CPM2 PIC code. Eliminated
> > > CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the
> > > interrupt mapping. Updated devicetree files to reflect that.
> > > Changed direct IC-related IO accesses to the IO accessors. Fixed
> > > all the sense values to keep coherency with ipic. In the current
> > > code, CPM2 stuff will have no IRQs and hence could be hardly usable.
> >
> > You seem to be adding significant stuff; include/asm-powerpc/mpc8260.h
> > is new, and there is this hunk in your patch 4/5:
> As I said, new io.h in powerpc broke compilation for both 8272 and 8560 that were committted.
I missed that report of breakage, can you give me more details on what
happens ?
next prev parent reply other threads:[~2007-01-22 19:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 0:41 [PATCH 1/5] [POWERPC] cpm2: CPM2 interrupt controller fix Vitaly Bordug
2007-01-13 0:42 ` [PATCH 2/5] [POWERPC] cpm_uart: OF-related fix for arch/powerpc Vitaly Bordug
2007-01-22 10:02 ` Paul Mackerras
2007-01-22 13:55 ` Vitaly Bordug
2007-01-13 0:42 ` [PATCH 3/5] [FS_ENET] OF-related fixup for FEC and SCC MAC's Vitaly Bordug
2007-01-22 10:07 ` Paul Mackerras
2007-01-22 14:04 ` Vitaly Bordug
2007-01-13 0:42 ` [PATCH 4/5] [POWERPC] Fix kernel build errors for mpc8272ads and mpc8560ads Vitaly Bordug
2007-01-13 0:42 ` [PATCH 5/5] [POWERPC] mpc8272ads: defconfig Vitaly Bordug
2007-01-22 9:57 ` [PATCH 1/5] [POWERPC] cpm2: CPM2 interrupt controller fix Paul Mackerras
2007-01-22 13:43 ` Vitaly Bordug
2007-01-22 19:55 ` Benjamin Herrenschmidt [this message]
2007-01-22 20:55 ` Vitaly Bordug
2007-01-22 21:13 ` Benjamin Herrenschmidt
2007-01-22 21:42 ` Vitaly Bordug
2007-01-24 10:07 ` Paul Mackerras
2007-01-24 13:05 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169495737.1582.7.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).