From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 10/14] ps3: get firmware version
Date: Thu, 25 Jan 2007 14:56:19 +1100 [thread overview]
Message-ID: <1169697379.24996.56.camel@localhost.localdomain> (raw)
In-Reply-To: <45B81891.1010309@am.sony.com>
On Wed, 2007-01-24 at 18:40 -0800, Geoff Levand wrote:
> +struct ps3_firmware_version {
> + u64 raw;
> + unsigned int major;
> + unsigned int minor;
> + unsigned int rev;
> +};
Wouldn't it be better to have a union here ?
Ben
next prev parent reply other threads:[~2007-01-25 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:40 [PATCH 10/14] ps3: get firmware version Geoff Levand
2007-01-25 3:56 ` Benjamin Herrenschmidt [this message]
2007-01-25 6:23 ` Arnd Bergmann
2007-01-26 2:59 ` Christoph Hellwig
2007-01-26 18:52 ` Geoff Levand
2007-01-26 20:25 ` Benjamin Herrenschmidt
2007-01-26 20:37 ` Nathan Lynch
2007-01-26 23:12 ` Geoff Levand
2007-01-26 23:27 ` Geoff Levand
2007-01-27 4:34 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169697379.24996.56.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).