From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id 85CAADDFE5
	for <linuxppc-dev@ozlabs.org>; Thu, 25 Jan 2007 14:56:30 +1100 (EST)
Subject: Re: [PATCH 10/14] ps3: get firmware version
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
In-Reply-To: <45B81891.1010309@am.sony.com>
References: <45B81891.1010309@am.sony.com>
Content-Type: text/plain
Date: Thu, 25 Jan 2007 14:56:19 +1100
Message-Id: <1169697379.24996.56.camel@localhost.localdomain>
Mime-Version: 1.0
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Wed, 2007-01-24 at 18:40 -0800, Geoff Levand wrote:

> +struct ps3_firmware_version {
> +	u64 raw;
> +	unsigned int major;
> +	unsigned int minor;
> +	unsigned int rev;
> +};

Wouldn't it be better to have a union here ?

Ben