From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 9/14] ps3: add interrupt alloc for outlets
Date: Fri, 26 Jan 2007 13:48:36 +1100 [thread overview]
Message-ID: <1169779716.24996.90.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0701251433330.31896@pademelon.sonytel.be>
> Do you have a preference which names to keep?
>
> 1. ps3_connect_irq() and ps3_disconnect_irq() resemble the LV1 calls they
> make,
> 2. ps3_alloc_irq() and ps3_free_irq() resemble the other
> ps3_{alloc,free}_*_irq() names.
>
> Personally I favor the latter.
Well, I think connect is a better illustration of the semantic. They
don't only alloc/free, since also connect. I think alloc/free is
actually confusing. Or maybe ps3_alloc_and_connect_irq() :-)
Ben.
prev parent reply other threads:[~2007-01-26 2:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:40 [PATCH 9/14] ps3: add interrupt alloc for outlets Geoff Levand
2007-01-25 3:55 ` Benjamin Herrenschmidt
2007-01-25 13:41 ` Geert Uytterhoeven
2007-01-25 23:56 ` Geoff Levand
2007-01-26 2:48 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169779716.24996.90.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).