linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jens Osterkamp <jens@de.ibm.com>
Cc: netdev@vger.kernel.org, James K Lewis <jim@jklewis.com>,
	linuxppc-dev@ozlabs.org, jgarzik@pobox.com,
	cbe-oss-dev@ozlabs.org
Subject: Re: spidernet: add improved phy support in sungem_phy.c
Date: Sat, 27 Jan 2007 07:20:47 +1100	[thread overview]
Message-ID: <1169842847.24996.106.camel@localhost.localdomain> (raw)
In-Reply-To: <200701261407.48237.jens@de.ibm.com>

On Fri, 2007-01-26 at 14:07 +0100, Jens Osterkamp wrote:
> This patch adds improved version of enable_fiber for both the 5421 and
> the 5461 phy. It is now possible to specify with these wether you want
> autonegotiation or not. This is needed for bladecenter switches where
> some expect autonegotiation and some dont seem to like this at all.
> Depending on this flag it sets phy->autoneg accordingly for the fiber mode.
> 
> More importantly it implements proper read_link and poll_link functions
> for both phys which can handle both copper and fiber mode by determining
> the medium first and then branching to the required functions. For fiber
> they all work fine, for copper they are not tested but return the result
> of the genmii_* function anyway which is supposed to work.
> 
> A "medium" variable in the phy struct is introduced to save the medium
> with which the phy is currently used.
> 
> The patch moves the genmii_* functions around to avoid foreward declarations.
> 
> Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
> Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>

Patch is whitespace damaged...

Ben.

  reply	other threads:[~2007-01-26 20:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26 13:07 spidernet: add improved phy support in sungem_phy.c Jens Osterkamp
2007-01-26 20:20 ` Benjamin Herrenschmidt [this message]
2007-01-26 22:31   ` Jens Osterkamp
2007-01-26 23:38     ` Francois Romieu
2007-01-30 22:30       ` Linas Vepstas
2007-02-01 10:55         ` Jens Osterkamp
2007-02-01 10:57         ` [PATCH] [v2] spidernet: add improved phy support Jens Osterkamp
2007-02-01 10:54       ` spidernet: add improved phy support in sungem_phy.c Jens Osterkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169842847.24996.106.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=jens@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=jim@jklewis.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).