From: Pavel Roskin <proski@gnu.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] Assign all PCI busses on G3 Blue & White
Date: Sun, 04 Feb 2007 03:16:08 -0500 [thread overview]
Message-ID: <1170576968.21644.55.camel@dv> (raw)
From: Pavel Roskin <proski@gnu.org>
G3 Blue & White is misconfigured by default so that CardBus controllers
in PCI slots don't work. The PCI bridge is programmed to only allow
access to bus 1 but not higher busses.
The patch forces the PCI busses to be reassigned if a Grackle controller
is found and the machine identifies itself as "PowerMac1,1"
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
My previous attempt to fix this bug can be found in this thread:
http://ozlabs.org/pipermail/linuxppc-dev/2004-May/thread.html#17056
The new patch relies on the existing common PCI code and doesn't poke
bridge registers itself. It would even do the right thing if a PCI or
CardBus bridge is inserted into the upper slot reserved for video cards
and connected directly to bus 0.
---
arch/powerpc/sysdev/grackle.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/grackle.c b/arch/powerpc/sysdev/grackle.c
index b6ec793..4205362 100644
--- a/arch/powerpc/sysdev/grackle.c
+++ b/arch/powerpc/sysdev/grackle.c
@@ -56,6 +56,8 @@ static inline void grackle_set_loop_snoop(struct pci_controller *bp, int enable)
void __init setup_grackle(struct pci_controller *hose)
{
setup_indirect_pci(hose, 0xfec00000, 0xfee00000);
+ if (machine_is_compatible("PowerMac1,1"))
+ pci_assign_all_buses = 1;
if (machine_is_compatible("AAPL,PowerBook1998"))
grackle_set_loop_snoop(hose, 1);
#if 0 /* Disabled for now, HW problems ??? */
--
Regards,
Pavel Roskin
next reply other threads:[~2007-02-04 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-04 8:16 Pavel Roskin [this message]
2007-02-05 0:11 ` [PATCH] Assign all PCI busses on G3 Blue & White Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170576968.21644.55.camel@dv \
--to=proski@gnu.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).