From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
cpufreq <cpufreq@lists.linux.org.uk>,
Ashok Raj <ashok.raj@intel.com>,
davej@codemonkey.org.uk
Subject: Re: CPU hotplug vs. cpufreq on ppc64
Date: Mon, 05 Feb 2007 12:39:16 +1100 [thread overview]
Message-ID: <1170639556.2620.75.camel@localhost.localdomain> (raw)
In-Reply-To: <1170360890.4036.19.camel@johannes.berg>
> which seems fine. However, when I resume, I get
> [ 168.446692] cpufreq-core: resuming cpu 0
> [ 168.446708] cpufreq-core: resuming cpu 1
> [ 168.446715] cpufreq-core: resuming cpu 2
> [ 168.446721] cpufreq-core: resuming cpu 3
> [ 168.624880] cpufreq-core: handle_update for cpu 0 called
> [ 168.624893] cpufreq-core: updating policy for CPU 0
> [ 168.624905] cpufreq-core: setting new policy for CPU 0: 1250000 - 2500000 kHz
> [ 168.624965] cpufreq-core: new min and max freqs are 1250000 - 2500000 kHz
> [ 168.624974] cpufreq-core: governor: change or update limits
> [ 168.624982] cpufreq-core: __cpufreq_governor for CPU 0, event 3
> [ 168.625009] cpufreq-core: target for CPU 0: 1250000 kHz, relation 0
> [ 169.232726] cpufreq-core: adding CPU 1
> [ 169.232741] cpufreq-core: initialization failed
> [ 169.239623] cpufreq-core: adding CPU 2
> [ 169.239636] cpufreq-core: initialization failed
> [ 169.247240] cpufreq-core: adding CPU 3
> [ 169.247255] cpufreq-core: initialization failed
>
> The question now is where this needs to be handled, and how. The driver
> can't really say that it initialised fine because it's still initialised
> on CPU0. However, I suppose that for real CPU hotplug cpufreq can't try
> to remember the pre-unplug groups either...
So you mean that the policy->cpus mask is lost on unplug/replug ? Hrm...
I'm not sure what's the best way to restore it. Do we have a cpufreq
backend callback on hotplug to restore things ?
Ben.
next prev parent reply other threads:[~2007-02-05 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 20:14 CPU hotplug vs. cpufreq on ppc64 Johannes Berg
2007-02-05 1:39 ` Benjamin Herrenschmidt [this message]
2007-02-05 6:45 ` Johannes Berg
2007-02-05 17:13 ` Jacob Shin
2007-02-05 17:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170639556.2620.75.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=ashok.raj@intel.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).