From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powermac: clean up PIC initialisation code
Date: Mon, 05 Feb 2007 12:41:48 +1100 [thread overview]
Message-ID: <1170639708.2620.77.camel@localhost.localdomain> (raw)
In-Reply-To: <1170375448.4036.33.camel@johannes.berg>
> --- linux-2.6-git.orig/arch/powerpc/platforms/powermac/setup.c 2007-02-02 01:09:19.949914899 +0100
> +++ linux-2.6-git/arch/powerpc/platforms/powermac/setup.c 2007-02-02 01:09:30.366914899 +0100
> @@ -756,7 +756,11 @@ define_machine(powermac) {
> .setup_arch = pmac_setup_arch,
> .init_early = pmac_init_early,
> .show_cpuinfo = pmac_show_cpuinfo,
> +#ifdef CONFIG_PPC32
> .init_IRQ = pmac_pic_init,
> +#else
> + .init_IRQ = pmac_mpic_init,
> +#endif
Not fan of having an ifdef here... I'd rather have a pmac_pic_init()
that does the right thing, maybe in setup.c
Ben.
next prev parent reply other threads:[~2007-02-05 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 0:17 [PATCH] powermac: clean up PIC initialisation code Johannes Berg
2007-02-05 1:41 ` Benjamin Herrenschmidt [this message]
2007-02-05 7:21 ` Johannes Berg
2007-02-05 8:58 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170639708.2620.77.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).