From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linuxppc-dev@ozlabs.org, linux-pm@lists.osdl.org,
Torrance <torrance123@gmail.com>
Subject: Re: [linux-pm] [RFC 07/10] powermac: support G5 CPU hotplug
Date: Wed, 07 Feb 2007 12:40:20 +0100 [thread overview]
Message-ID: <1170848420.6798.8.camel@johannes.berg> (raw)
In-Reply-To: <20070206124212.GD8662@elf.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
Hi,
> > + /* it seems to be possible that we died from within
> > + * an interrupt ... reset the in-irq counts */
> > + task_thread_info(paca[cpu].__current)->preempt_count &=
> > + ~(SOFTIRQ_MASK|HARDIRQ_MASK);
> > +
> > cpu_idle();
> > return 0;
>
> This is quite a nasty hack. Are you sure?
>
> I've seen similar weirdness on pc, and it was caused by
> swsusp-copying-code using FPU and incrementing preempt_count...
I know. I'm not really happy with it. But I can't figure out where the
hardirq count can be incremented. The preempt count is fine (well, in my
latest patchset, this one forgot one spot), but the hard irq count is
not. Which is really strange because we only use that for actual in-irq
stuff...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-02-07 11:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 18:30 [PATCH/RFC 00/10] suspend to disk for powermac G5 Johannes Berg
2007-02-05 18:30 ` [PATCH 01/10] dont copy pages that arent RAM Johannes Berg
2007-02-05 18:30 ` [PATCH 02/10] windfarm: dont die on suspend thread signal Johannes Berg
2007-02-05 22:43 ` Christoph Hellwig
2007-02-05 22:54 ` [PATCH revision 2] " Johannes Berg
2007-02-05 23:04 ` Benjamin Herrenschmidt
2007-02-05 23:04 ` Benjamin Herrenschmidt
2007-02-05 22:54 ` [PATCH 02/10] " Andrew Morton
2007-02-05 22:55 ` Johannes Berg
2007-02-05 22:58 ` Benjamin Herrenschmidt
2007-02-05 18:30 ` [PATCH 03/10] powerpc: fix comment in kernel/irq.c Johannes Berg
2007-02-05 22:59 ` Benjamin Herrenschmidt
2007-02-05 23:18 ` Andrew Morton
2007-02-05 23:53 ` Benjamin Herrenschmidt
2007-02-05 18:30 ` [PATCH 04/10] powermac: clean up PIC initialisation code Johannes Berg
2007-02-08 4:41 ` Paul Mackerras
2007-02-08 13:03 ` Johannes Berg
2007-02-05 18:30 ` [PATCH 05/10] powermac: generic time suspend/resume code Johannes Berg
2007-02-19 10:00 ` [linux-pm] " Guennadi Liakhovetski
2007-02-19 23:19 ` Guennadi Liakhovetski
2007-02-05 18:30 ` [RFC 06/10] powerpc: MPIC sys_device & suspend/resume Johannes Berg
2007-02-07 12:24 ` Johannes Berg
2007-02-05 18:30 ` [RFC 07/10] powermac: support G5 CPU hotplug Johannes Berg
2007-02-06 12:42 ` [linux-pm] " Pavel Machek
2007-02-07 11:40 ` Johannes Berg [this message]
2007-02-07 12:23 ` Johannes Berg
2007-02-05 18:30 ` [RFC 08/10] powerpc: dart iommu suspend Johannes Berg
2007-02-06 1:19 ` Olof Johansson
2007-02-06 1:26 ` Johannes Berg
2007-02-06 1:52 ` Johannes Berg
2007-02-07 12:22 ` Johannes Berg
2007-02-06 12:40 ` [linux-pm] " Pavel Machek
2007-02-07 11:42 ` Johannes Berg
2007-02-05 18:30 ` [RFC 09/10] powermac: suspend to disk on G5 Johannes Berg
2007-02-05 18:30 ` [RFC 10/10] powermac: fix G5-cpufreq for cpu on/offline Johannes Berg
2007-02-07 12:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170848420.6798.8.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=pavel@ucw.cz \
--cc=torrance123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).