linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Added QE to the list of default scanned OF devices
Date: Fri, 09 Feb 2007 09:27:47 +1100	[thread overview]
Message-ID: <1170973667.2620.376.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0702081056250.15256@ld0175-tx32.am.freescale.net>

On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
>  arch/powerpc/kernel/of_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.

Ben.

> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
> index b734517..43c5a00 100644
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
>  	{ .type = "plb4", },
>  	{ .type = "opb", },
>  	{ .type = "ebc", },
> +	{ .type = "qe", },
>  	{},
>  };
>  

  parent reply	other threads:[~2007-02-08 22:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 16:56 [PATCH] Added QE to the list of default scanned OF devices Andy Fleming
2007-02-08 17:11 ` Kumar Gala
2007-02-08 22:27 ` Benjamin Herrenschmidt [this message]
2007-02-08 22:56   ` Kumar Gala
2007-02-08 23:25     ` Kumar Gala
2007-02-09  1:00       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170973667.2620.376.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=afleming@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).