[PATCH 0/4] spidernet: support for Celleb

[PATCH 0/4] spidernet: support for Celleb

[Ishizaki Kou]

This is a revised spidernet patch set based on
netdev-2.6.git#upstream.

This patch set is merged Jens-san's spidernet patch and works on
Toshiba Cell reference set (aka Celleb). 
It requires Jens-san's phy patch
(http://ozlabs.org/pipermail/linuxppc-dev/2007-February/030987.html).

Ignore our previos patch set, and try this patch set on Cell Blade,
please (sorry for asking a lot).

Best regards,
Kou Ishizaki

Re: [PATCH 0/4] spidernet: support for Celleb

[Jeff Garzik]

Ishizaki Kou wrote:
> This is a revised spidernet patch set based on
> netdev-2.6.git#upstream.
> 
> This patch set is merged Jens-san's spidernet patch and works on
> Toshiba Cell reference set (aka Celleb). 
> It requires Jens-san's phy patch
> (http://ozlabs.org/pipermail/linuxppc-dev/2007-February/030987.html).

I'm unsure of the status of the phy patch, so will put this patchset on 
hold until that is resolved

Re: [PATCH 0/4] spidernet: support for Celleb

[Benjamin Herrenschmidt]

On Wed, 2007-02-07 at 17:15 -0500, Jeff Garzik wrote:
> Ishizaki Kou wrote:
> > This is a revised spidernet patch set based on
> > netdev-2.6.git#upstream.
> > 
> > This patch set is merged Jens-san's spidernet patch and works on
> > Toshiba Cell reference set (aka Celleb). 
> > It requires Jens-san's phy patch
> > (http://ozlabs.org/pipermail/linuxppc-dev/2007-February/030987.html).
> 
> I'm unsure of the status of the phy patch, so will put this patchset on 
> hold until that is resolved

PHY patch is mostly Ok except I don't like that "medium" variable Jens
added which isn't used anywhere in sungem_phy. Jens, can you resend a
version without that ? If you need that variable in spidernet itself,
then put it there :-)

Also, the GMII_* constants, are they standard or 54xx specific ? If the
later, then change the name to reflect that.

Once I have the new patch, I'll give it a test on G5 and if it's ok, it
will be good to go for 2.6.21

Cheers,
Ben.

Re: [PATCH 0/4] spidernet: support for Celleb

[Jens Osterkamp]

> PHY patch is mostly Ok except I don't like that "medium" variable Jens
> added which isn't used anywhere in sungem_phy. Jens, can you resend a
> version without that ? If you need that variable in spidernet itself,
> then put it there :-)

That was the idea I had first, I'll change that.

> Also, the GMII_* constants, are they standard or 54xx specific ? If the
> later, then change the name to reflect that.

I'll check...

Jens

Re: [PATCH 0/4] spidernet: support for Celleb

[Linas Vepstas]

On Wed, Feb 07, 2007 at 05:49:50PM +0900, Ishizaki Kou wrote:
> This is a revised spidernet patch set based on
> netdev-2.6.git#upstream.

Tested this series of patches together with Jen's "version 3" patch,
it worked for me. Code looks reasonable.  Thus

Acked-by: Linas Vepstas <linas@austin.ibm.com>

I'm somewhat unclear as to whethr I should be doing 

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>

instead.

--linas

Re: [PATCH 0/4] spidernet: support for Celleb

[Benjamin Herrenschmidt]

On Mon, 2007-02-12 at 17:49 -0600, Linas Vepstas wrote:
> On Wed, Feb 07, 2007 at 05:49:50PM +0900, Ishizaki Kou wrote:
> > This is a revised spidernet patch set based on
> > netdev-2.6.git#upstream.
> 
> Tested this series of patches together with Jen's "version 3" patch,
> it worked for me. Code looks reasonable.  Thus
> 
> Acked-by: Linas Vepstas <linas@austin.ibm.com>
> 
> I'm somewhat unclear as to whethr I should be doing 
> 
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>

If the patch wasn't actually handled and passed-on by you or modified by
you, then no. Acked-by is the way to go.

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> too while at
it.

Ben.

Re: [PATCH 0/4] spidernet: support for Celleb

[Ishizaki Kou]

Linas-san, Jens-san,

> Tested this series of patches together with Jen's "version 3" patch,
> it worked for me. Code looks reasonable.  Thus

We tried Jens-san's v3 patch on Celleb, and it works for us.

We also need Linas-san's patch set which includes bug-fix and makes
the code compilable etc. But our previous patch set conflicts with
Linas-san's patch set.

So we will post a revised patch set for spider_net, which is based on
Jens-san's phy patch and Linas-san's spider_net patch.  The revised
patch set will differ from our previous patch set only by editorial
changes, so we think it will be ready to go in.


Best regards,
Kou Ishizaki

Re: [PATCH 0/4] spidernet: support for Celleb

[Linas Vepstas]

Jeff, 

I think we are all in agreement about this patch set, please commit.

--linas

On Wed, Feb 14, 2007 at 04:51:07PM +0900, Ishizaki Kou wrote:
> 
> We also need Linas-san's patch set which includes bug-fix and makes
> the code compilable etc. But our previous patch set conflicts with
> Linas-san's patch set.

! 

Sorry. I thought I tried it both ways, and although the line numbers
would be off, I don't remember any outright patch conflicts. I thought
I'd gottoen lucky, guess not.

[PATCH 0/4] spidernet: support for Celleb

[Ishizaki Kou]

Jeff-san,

This is a revised patch set for spider_net to work on Celleb.

This patch set is based on Jens-san's v3 phy patch and Linas-san's
spider_net patch.

Please apply our patch set with them.


Note: You need not apply Jens-san's spidernet patch because our patch
set includes it.

Best regards,
Kou Ishizaki