From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Geert.Uytterhoeven@sonycom.com, linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [patch 1/4] ps3fb: thread updates
Date: Fri, 16 Feb 2007 08:43:37 +1100 [thread overview]
Message-ID: <1171575817.5644.44.camel@localhost.localdomain> (raw)
In-Reply-To: <20070215175007.GA10817@lst.de>
On Thu, 2007-02-15 at 18:50 +0100, Christoph Hellwig wrote:
> On Thu, Feb 15, 2007 at 04:23:02PM +0100, Geert.Uytterhoeven@sonycom.com wrote:
> > + do {
> > + try_to_freeze();
> > + error = down_interruptible(&ps3fb.sem);
> > + if (!error && !atomic_read(&ps3fb.ext_flip))
> > ps3fb_sync(0); /* single buffer */
>
> this still can deadlock when calling kthread_stop. You really want
> to use wake_up_process to kick this thread or use a workqueue.
kthread_stop does wake_up_process no ? However, that might not get you
out of interruptible if you don't also have signal_pending...
Ben.
next prev parent reply other threads:[~2007-02-15 21:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 15:23 [patch 0/4] PS3 AV/FB updates Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 1/4] ps3fb: thread updates Geert.Uytterhoeven
2007-02-15 17:50 ` Christoph Hellwig
2007-02-15 21:43 ` Benjamin Herrenschmidt [this message]
2007-02-16 0:59 ` Andrew Morton
2007-02-16 15:58 ` Geert Uytterhoeven
2007-02-16 16:00 ` [PATCH 1/4 (updated)] " Geert Uytterhoeven
2007-02-16 16:38 ` Christoph Hellwig
2007-02-16 17:33 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2007-02-19 14:07 ` Geert Uytterhoeven
2007-02-20 10:33 ` Geert Uytterhoeven
2007-02-20 10:42 ` [PATCH 1/4 (final?)] " Geert Uytterhoeven
2007-02-21 23:20 ` Andrew Morton
2007-02-22 8:21 ` Geert Uytterhoeven
2007-02-22 12:16 ` Geert Uytterhoeven
2007-02-22 12:17 ` [PATCH 1/4 (final)] " Geert Uytterhoeven
2007-02-16 16:03 ` [PATCH extra] ps3fb: atomic fixes Geert Uytterhoeven
2007-02-16 16:36 ` [patch 1/4] ps3fb: thread updates Christoph Hellwig
2007-02-15 15:23 ` [patch 2/4] ps3av: " Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 3/4] ps3fb: kill superfluous zero initializations Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 4/4] ps3av: misc updates Geert.Uytterhoeven
2007-02-15 15:48 ` [Linux-fbdev-devel] [patch 0/4] PS3 AV/FB updates James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171575817.5644.44.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).