From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Andrew Morton <akpm@osdl.org>, Olaf Hering <olaf@aepfle.de>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jeff@garzik.org>,
linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org,
Paul Mackeras <paulus@samba.org>
Subject: Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives
Date: Sat, 17 Feb 2007 08:41:19 +1100 [thread overview]
Message-ID: <1171662079.5644.77.camel@localhost.localdomain> (raw)
In-Reply-To: <45D5C5CC.9070406@ru.mvista.com>
On Fri, 2007-02-16 at 17:55 +0300, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> >> I'm sorry, how those 2 drivers can be equivalent?! The pata_winbond driver
> >>is for VLB only, sl81c105 was for PCI only -- you certainly want to use
> >>pata_sl82c105 (indeed better version of sl82c105 driver).
>
> > I was under the impression that with your fixes these drivers
> > (sl82c105 and pata_sl82c105) are functionally equivalent.
>
> They're not yet equivalent. pata_sl82c105 supports all MWDMA modes,
> sl82c105 still supports only MWDMA2.
BTW, the "old ide" sl82c105 currently upstream produces warnings on 64
bits platforms about conversion between int and pointers of different
sizes. I didn't have time to look closely yesterday though, could be
harmless.
Ben.
next prev parent reply other threads:[~2007-02-16 21:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 20:35 [PATCH] move variables in drivers/macintosh to bss Olaf Hering
2007-02-10 20:36 ` [PATCH] add delay around sl82c105_reset_engine calls Olaf Hering
2007-02-10 20:37 ` [PATCH] cleanup variable usage in mesh interrupt handler Olaf Hering
2007-02-10 20:38 ` [PATCH] mark winbond IDE PCI resources with start 0 as unassigned Olaf Hering
2007-02-10 20:40 ` [PATCH] correct AC Power: in /proc/pmu/info on ibook1 Olaf Hering
2007-02-15 23:09 ` [PATCH] add delay around sl82c105_reset_engine calls Jeff Garzik
2007-02-16 9:20 ` [PATCH] use winbond libata instead of ide driver for pseries CD drives Olaf Hering
2007-02-16 13:52 ` Sergei Shtylyov
2007-02-16 14:51 ` Sergei Shtylyov
2007-02-16 14:53 ` Bartlomiej Zolnierkiewicz
2007-02-16 14:55 ` Sergei Shtylyov
2007-02-16 15:09 ` Bartlomiej Zolnierkiewicz
2007-02-16 15:06 ` Sergei Shtylyov
2007-02-16 15:11 ` Sergei Shtylyov
2007-02-16 21:41 ` Benjamin Herrenschmidt [this message]
2007-02-16 14:46 ` Bartlomiej Zolnierkiewicz
2007-02-16 14:51 ` Bartlomiej Zolnierkiewicz
2007-02-16 17:37 ` Olaf Hering
2007-02-17 20:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171662079.5644.77.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
--cc=paulus@samba.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).