linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: Make sure we populate the initroot filesystem late enough
Date: Sun, 25 Feb 2007 20:17:40 -0500	[thread overview]
Message-ID: <1172452660.3971.33.camel@shinybook.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702251614420.12485@woody.linux-foundation.org>

On Sun, 2007-02-25 at 16:24 -0800, Linus Torvalds wrote:
> Hmm. No, I don't think that should be a problem. free_initmem() only 
> happens at the very, after do_basic_setup() has been run, which
> includes all the initcall stuff.

I'm inclined to agree that it _shouldn't_ be a problem. Nevertheless,
even this hack seems sufficient to 'fix' it:

--- arch/powerpc/mm/init_32.c   2007-02-25 20:06:54.000000000 -0500
+++ arch/powerpc/mm/init_32.c.not       2007-02-25 20:06:41.000000000 -0500
@@ -243,13 +243,14 @@ void free_initmem(void)
 #ifdef CONFIG_BLK_DEV_INITRD
 void free_initrd_mem(unsigned long start, unsigned long end)
 {
        if (start < end)
-               printk ("Freeing initrd memory: %ldk freed\n", (end - start) >> 10);
+               printk ("NOT Freeing initrd memory: %ldKiB would be freed\n", (end - start) >> 10);
+       return;
        for (; start < end; start += PAGE_SIZE) {
                ClearPageReserved(virt_to_page(start));
                init_page_count(virt_to_page(start));
                free_page(start);
                totalram_pages++;
        }
 }
 #endif


-- 
dwmw2

  parent reply	other threads:[~2007-02-26  1:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200612112059.kBBKx1j7022473@hera.kernel.org>
2007-02-26  0:00 ` Make sure we populate the initroot filesystem late enough David Woodhouse
2007-02-26  0:24   ` Linus Torvalds
2007-02-26  0:45     ` David Woodhouse
2007-02-26  1:17     ` David Woodhouse [this message]
2007-02-26  3:45       ` Linus Torvalds
2007-02-26  4:01         ` David Woodhouse
2007-02-26  4:13           ` Linus Torvalds
2007-02-26 16:24             ` David Woodhouse
2007-02-26  6:59           ` William Lee Irwin III
2007-02-26 15:53           ` Benjamin Herrenschmidt
2007-02-26 16:00             ` Segher Boessenkool
2007-02-26 16:44           ` Milton Miller
2007-02-26 20:57             ` David Woodhouse
2007-02-26 21:17               ` Linus Torvalds
2007-02-27  6:46                 ` Benjamin Herrenschmidt
2007-02-26 15:51       ` Benjamin Herrenschmidt
2007-02-26 20:51         ` Kumar Gala
2007-02-26 19:27   ` john stultz
2007-02-26 22:27     ` Paul TBBle Hampson
2007-02-27  6:48       ` Benjamin Herrenschmidt
2007-02-27 11:58         ` Segher Boessenkool
2007-02-28  6:43           ` Benjamin Herrenschmidt
2007-02-28 10:13             ` David Woodhouse
2007-03-01  0:30               ` Michael Ellerman
2007-03-12 23:01                 ` Paul TBBle Hampson
2007-03-13  3:03                   ` Kumar Gala
2007-03-13  7:03                   ` Benjamin Herrenschmidt
2007-03-16  7:20                     ` Paul TBBle Hampson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172452660.3971.33.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).