From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: MOKUNO Masakazu <mokuno@sm.sony.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: Remove some redunant isync instructions
Date: Mon, 26 Feb 2007 16:54:51 +0100 [thread overview]
Message-ID: <1172505291.11949.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20070226171709.A2E8.MOKUNO@sm.sony.co.jp>
On Mon, 2007-02-26 at 17:21 +0900, MOKUNO Masakazu wrote:
> Remove some redundant isync instructions.
>
> enable_64b_mode() already does an isync, so there is no need to do it again.
>
> Signed-off-by: MOKUNO, Masakazu <mokuno@sm.sony.co.jp>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/kernel/head_64.S | 2 --
> 1 files changed, 2 deletions(-)
>
> --- ps3-linux-dev.orig/arch/powerpc/kernel/head_64.S
> +++ ps3-linux-dev/arch/powerpc/kernel/head_64.S
> @@ -1555,7 +1555,6 @@ _GLOBAL(generic_secondary_smp_init)
>
> /* turn on 64-bit mode */
> bl .enable_64b_mode
> - isync
>
> /* Set up a paca value for this processor. Since we have the
> * physical cpu id in r24, we need to search the pacas to find
> @@ -1851,7 +1850,6 @@ __secondary_start_pmac_0:
> _GLOBAL(pmac_secondary_start)
> /* turn on 64-bit mode */
> bl .enable_64b_mode
> - isync
>
> /* Copy some CPU settings from CPU 0 */
> bl .__restore_cpu_ppc970
>
> --
> Masakazu MOKUNO
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2007-02-26 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 8:21 [PATCH] powerpc: Remove some redunant isync instructions MOKUNO Masakazu
2007-02-26 14:01 ` Segher Boessenkool
2007-02-26 15:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172505291.11949.17.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mokuno@sm.sony.co.jp \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).