linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jake Moilanen <moilanen@austin.ibm.com>
To: paulus@samba.org, olof@lixom.net
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] DMA 4GB boundary protection
Date: Fri, 02 Mar 2007 15:49:43 -0600	[thread overview]
Message-ID: <1172872183.5310.145.camel@goblue> (raw)

There are many adapters which can not handle DMAing acrosss any 4 GB
boundary.  For instance the latest Emulex adapters.  

This normally is not an issue as firmware gives us dma-windows under
4gigs.  However, some of the new System-P boxes have dma-windows above
4gigs, and this present a problem.

I propose fixing it in the IOMMU allocation instead of making each
driver protect against it as it is more efficient, and won't require
changing every driver which has not considered this issue.

This patch checks to see if the mapping spans a 4 gig boundary, and if
it does, retries the allocation.  It tries the next allocation at the
start of the crossed 4 gig boundary.

Signed-off-by: Jake Moilanen <moilanen@austin.ibm.com>
---

 arch/powerpc/kernel/iommu.c |   10 ++++++++++
 1 files changed, 10 insertions(+)

Index: powerpc/arch/powerpc/kernel/iommu.c
===================================================================
--- powerpc.orig/arch/powerpc/kernel/iommu.c
+++ powerpc/arch/powerpc/kernel/iommu.c
@@ -76,6 +76,7 @@ static unsigned long iommu_range_alloc(s
                                        unsigned int align_order)
 { 
 	unsigned long n, end, i, start;
+	unsigned long start_addr, end_addr;
 	unsigned long limit;
 	int largealloc = npages > 15;
 	int pass = 0;
@@ -146,6 +147,15 @@ static unsigned long iommu_range_alloc(s
 		}
 	}
 
+	/* DMA cannot cross 4 GB boundary */
+	start_addr = (n + tbl->it_offset) << PAGE_SHIFT;
+	end_addr = (end + tbl->it_offset) << PAGE_SHIFT;
+	if ((start_addr >> 32) != (end_addr >> 32)) {
+		end_addr &= 0xffffffff00000000l;
+		start = (end_addr >> PAGE_SHIFT) - tbl->it_offset;
+		goto again;
+	}
+
 	for (i = n; i < end; i++)
 		if (test_bit(i, tbl->it_map)) {
 			start = i+1;

             reply	other threads:[~2007-03-02 21:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 21:49 Jake Moilanen [this message]
2007-03-02 22:27 ` [PATCH] DMA 4GB boundary protection Olof Johansson
2007-03-03  8:27   ` Benjamin Herrenschmidt
2007-03-03 23:25     ` Olof Johansson
2007-03-04  5:17     ` Christoph Hellwig
2007-03-04  5:52       ` Olof Johansson
2007-03-03 23:29 ` Olof Johansson
2007-03-03 23:32   ` Segher Boessenkool
2007-03-03 23:57     ` Olof Johansson
2007-03-21 21:05   ` Jake Moilanen
2007-03-21 21:39     ` Olof Johansson
2007-03-22 17:53     ` Olof Johansson
2007-03-22 17:47       ` Jake Moilanen
2007-03-22 22:52       ` Segher Boessenkool
2007-03-27 20:10       ` Jake Moilanen
2007-03-27 20:55         ` Benjamin Herrenschmidt
2007-03-27 23:48         ` Paul Mackerras
2007-03-28 15:56         ` Olof Johansson
2007-03-28 18:17           ` Jake Moilanen
2007-03-28 23:23             ` Benjamin Herrenschmidt
2007-03-29 13:44               ` Jake Moilanen
2007-03-29 14:52                 ` Olof Johansson
2007-03-29 21:54                 ` Benjamin Herrenschmidt
2007-04-23 12:22                 ` Paul Mackerras
2007-04-24  3:07                   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172872183.5310.145.camel@goblue \
    --to=moilanen@austin.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).