Re: [PATCH] DMA 4GB boundary protection

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2007-03-02 at 16:27 -0600, Olof Johansson wrote:
> On Fri, Mar 02, 2007 at 03:49:43PM -0600, Jake Moilanen wrote:
> > There are many adapters which can not handle DMAing acrosss any 4 GB
> > boundary.  For instance the latest Emulex adapters.  
> > 
> > This normally is not an issue as firmware gives us dma-windows under
> > 4gigs.  However, some of the new System-P boxes have dma-windows above
> > 4gigs, and this present a problem.
> > 
> > I propose fixing it in the IOMMU allocation instead of making each
> > driver protect against it as it is more efficient, and won't require
> > changing every driver which has not considered this issue.
> 
> Sorry, but you need to fix the drivers. They might be used on a system
> without an IOMMU, or with direct mapping. It's particularily likely in
> the case of DAC-capable devices, and that's the only case for which you
> can cross a 4GB boundary in the first place.

Hrm... ok, that would be ideal, _but_

- We currently don't have platforms that DMA > 32 bits and don't have an
iommu

- Drivers are broken -today- and I doubt they can all be audited and
fixed (and fixes bacported to distros) quickly

- That problem is very common and can be very hard to debug when it
happens.

So while I agree, the logical fix would be in the drivers, I think that
-also- making sure the iommu code will not hand off sections crossing 4G
boundaries does make some sense. It will at least reduce the likehood of
strange and hard to debug problems on those setups that do have an iommu
and >4G of RAM, which is pretty much all of them at the moment on ppc64.

Can you double check the correctness of the patch ? I'll have a better
look myself next week hopefully.

Ben.