From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI
Date: Mon, 05 Mar 2007 10:02:08 +0100 [thread overview]
Message-ID: <1173085328.8184.70.camel@localhost.localdomain> (raw)
In-Reply-To: <200703041959.46872.arnd@arndb.de>
On Sun, 2007-03-04 at 19:59 +0100, Arnd Bergmann wrote:
> On Sunday 04 March 2007, Benjamin Herrenschmidt wrote:
> > On Sun, 2007-03-04 at 15:07 +0100, Arnd Bergmann wrote:
> > > On Sunday 04 March 2007 07:04:44 Stephen Rothwell wrote:
> > > > config PCI
> > > > bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \
> > > > - || PPC_MPC52xx || (EMBEDDED && PPC_ISERIES) || MPC7448HPC2 || PPC_PS3
> > > > + || PPC_MPC52xx || (EMBEDDED && (PPC_PSERIES || PPC_ISERIES)) \
> > > > + || MPC7448HPC2 || PPC_PS3
> > >
> > I dislike the giant conditional though.
>
> How about changing it to
>
> config PCI_ENABLE
> bool
Call it PCI_CAPABLE rather...
Ben.
next prev parent reply other threads:[~2007-03-05 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 5:58 [PATCH 1/6] [POWERPC] create and use set_pci_dma_ops Stephen Rothwell
2007-03-04 6:02 ` [PATCH 2/6] [POWERPC] create and use get_pci_dma_ops( Stephen Rothwell
2007-03-04 6:03 ` [PATCH 3/6] [POWERPC] make iSeries build without CONFIG_PCI Stephen Rothwell
2007-03-04 6:04 ` [PATCH 4/6] [POWERPC] allow pSeries to " Stephen Rothwell
2007-03-04 6:05 ` [PATCH 5/6] [POWERPC] allow xmon to build without CONFIG_DEBUG_BUGVERBOSE Stephen Rothwell
2007-03-04 6:07 ` [PATCH 6/6] [POWERPC] make find_and_init_pbs() a void function Stephen Rothwell
2007-03-04 14:07 ` [PATCH 4/6] [POWERPC] allow pSeries to build without CONFIG_PCI Arnd Bergmann
2007-03-04 16:37 ` Anton Blanchard
2007-03-04 18:43 ` Benjamin Herrenschmidt
2007-03-04 18:59 ` Arnd Bergmann
2007-03-05 9:02 ` Benjamin Herrenschmidt [this message]
2007-03-05 9:06 ` Geert Uytterhoeven
2007-03-06 1:57 ` Stephen Rothwell
2007-03-07 5:47 ` [POWERPC] Clean up deciding when PCI is selectable Stephen Rothwell
2007-03-07 6:53 ` Benjamin Herrenschmidt
2007-03-05 16:31 ` [PATCH 2/6] [POWERPC] create and use get_pci_dma_ops( Will Schmidt
2007-03-05 22:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173085328.8184.70.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).