From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Loeliger <jdl@freescale.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Do not skip PCI Express to PCI bridge when scanning OF node
Date: Thu, 08 Mar 2007 10:45:32 +0100 [thread overview]
Message-ID: <1173347132.8635.15.camel@localhost.localdomain> (raw)
In-Reply-To: <1173292541.23776.125.camel@ld0161-tx32>
On Wed, 2007-03-07 at 12:35 -0600, Jon Loeliger wrote:
> From: Haiying Wang <haiying.wang@freescale.com>
>
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> Signed-off-by: Haiying Wang <haiying.wang@freescale.com>
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
> arch/powerpc/kernel/prom_parse.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
> index ea6fd55..0809977 100644
> --- a/arch/powerpc/kernel/prom_parse.c
> +++ b/arch/powerpc/kernel/prom_parse.c
> @@ -267,7 +267,7 @@ int of_irq_map_pci(struct pci_dev *pdev, struct of_irq *out_irq)
> ppdev = pdev->bus->self;
>
> /* Ouch, it's a host bridge... */
> - if (ppdev == NULL) {
> + if (ppdev == NULL || ppdev->devfn == 0) {
No way. There is nothing "special" per spec with devfn == 0.
What exactly is that supposed to do ?
Ben.
prev parent reply other threads:[~2007-03-08 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 18:35 [PATCH] Do not skip PCI Express to PCI bridge when scanning OF node Jon Loeliger
2007-03-07 20:00 ` Kumar Gala
2007-03-08 9:45 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173347132.8635.15.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).