linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-arch@vger.kernel.org, ppc-dev <linuxppc-dev@ozlabs.org>,
	paulus@samba.org, rmk@arm.linux.org.uk, ralf@linux-mips.org
Subject: Re: [PATCH] [POWERPC] Wire up sys_sync_file_range
Date: Fri, 09 Mar 2007 06:55:41 +0000	[thread overview]
Message-ID: <1173423341.3461.548.camel@pmac.infradead.org> (raw)
In-Reply-To: <20070309152201.027c2bf5.sfr@canb.auug.org.au>

On Fri, 2007-03-09 at 15:22 +1100, Stephen Rothwell wrote:
> This requires an architecture specific compat routine as u64s are passed
> in odd/even (high/low) register pairs on ppc32.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Doesn't that apply to ARM and to 32-bit MIPS too? And perhaps others?

> --- a/arch/powerpc/kernel/sys_ppc32.c
> +++ b/arch/powerpc/kernel/sys_ppc32.c
> @@ -814,3 +814,12 @@ asmlinkage long compat_sys_request_key(const char __user *_type,
>  	return sys_request_key(_type, _description, _callout_info, destringid);
>  }
>  
> +asmlinkage long compat_sys_sync_file_range(int fd, u32 unused,
> +		u32 offset_high, u32 offset_low,
> +		u32 nbytes_high, u32 nbytes_low,
> +		compat_uint_t flags)
> +{
> +	return sys_sync_file_range(fd, (loff_t)offset_high << 32 | offset_low,
> +			(loff_t)nbytes_high << 32 | nbytes_low,
> +			(unsigned int)flags);
> +}

-- 
dwmw2

  reply	other threads:[~2007-03-09  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-09  4:22 [PATCH] [POWERPC] Wire up sys_sync_file_range Stephen Rothwell
2007-03-09  6:55 ` David Woodhouse [this message]
2007-03-09  7:13   ` David Miller
2007-03-09 11:59     ` Ralf Baechle
2007-03-15 10:23       ` Stephen Rothwell
2007-03-17 15:10 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173423341.3461.548.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).