From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
paulus@samba.org, linux-kernel@vger.kernel.org,
mbligh@google.com
Subject: Re: [PATCH] Fix atomicity of TIF update in flush_thread() for powerpc
Date: Fri, 09 Mar 2007 14:06:39 +0100 [thread overview]
Message-ID: <1173445599.24454.15.camel@localhost.localdomain> (raw)
In-Reply-To: <20070309024525.GB9462@Krystal>
.../...
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Nice catch !
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -476,8 +476,13 @@ void flush_thread(void)
> #ifdef CONFIG_PPC64
> struct thread_info *t = current_thread_info();
>
> - if (t->flags & _TIF_ABI_PENDING)
> - t->flags ^= (_TIF_ABI_PENDING | _TIF_32BIT);
> + if (test_tsk_thread_flag(tsk, TIF_ABI_PENDING)) {
> + clear_tsk_thread_flag(tsk, TIF_ABI_PENDING);
> + if (test_tsk_thread_flag(tsk, TIF_32BIT))
> + clear_tsk_thread_flag(tsk, TIF_32BIT);
> + else
> + set_tsk_thread_flag(tsk, TIF_32BIT);
> + }
> #endif
>
> discard_lazy_cpu_state();
next prev parent reply other threads:[~2007-03-09 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 2:45 [PATCH] Fix atomicity of TIF update in flush_thread() for powerpc Mathieu Desnoyers
2007-03-09 13:06 ` Benjamin Herrenschmidt [this message]
2007-03-10 8:19 ` Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2007-03-10 8:23 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173445599.24454.15.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).