From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, sfr@canb.auug.org.au
Subject: Re: [PATCH 1/2] [powerpc] export symbols for use by lparcfg
Date: Mon, 12 Mar 2007 17:07:40 -0500 [thread overview]
Message-ID: <1173737260.7716.25.camel@localhost> (raw)
In-Reply-To: <20070312213258.GA13648@lst.de>
On Mon, 2007-12-03 at 22:32 +0100, Christoph Hellwig wrote:
> On Mon, Mar 12, 2007 at 01:21:14PM -0600, Will Schmidt wrote:
> >
> > Updates the Kconfig to allow lparcfg to be built as a module, and
> > add the necessary EXPORT_SYMBOLS needed for a successful build.
> >
> > Signed-off-by: Will Schmidt <will_schmidt@vnet.ibm.com>
>
> NACK. This is an awfull lot of deep down internal symbols, and there
> is no reason to make this a module. If you fear about the space useage
> on non-phype platforms better reintroduce something like the
> __pmac/__chrp markers of the old ppc32 port.
Understood.. This used to be a module, I just wanted it to be a
module again. I'm not worried about the space usage, honest. :-)
With this and Nathans response I'll happily second your NACK.
-Will
prev parent reply other threads:[~2007-03-12 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 19:21 [PATCH 1/2] [powerpc] export symbols for use by lparcfg Will Schmidt
2007-03-12 19:21 ` [PATCH 2/2] [powerpc] replace if-then-else with a switch statement Will Schmidt
2007-03-12 20:24 ` [PATCH 1/2] [powerpc] export symbols for use by lparcfg Nathan Lynch
2007-03-12 22:05 ` Will Schmidt
2007-03-12 22:14 ` Nathan Lynch
2007-03-12 21:32 ` Christoph Hellwig
2007-03-12 22:07 ` Will Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173737260.7716.25.camel@localhost \
--to=will_schmidt@vnet.ibm.com \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).