linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Zhang Wei-r63237 <Wei.Zhang@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
	Wang Haiying-r54964 <Haiying.Wang@freescale.com>
Subject: RE: [PATCH] Add irq host and hwirq pair fields to output whenshowing interrupts.
Date: Tue, 13 Mar 2007 14:52:06 +0100	[thread overview]
Message-ID: <1173793926.24454.74.camel@localhost.localdomain> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C131E7F@zch01exm26.fsl.freescale.net>


> > Now, regarding the patch itself, printing the hw irq is not 
> > that useful
> > without some indication of which host it belongs to. Best is to add a
> > name() or something like that to the host ops.
> > 
> 
> Sure, can I use the PIC controller node full name from of_tree as the
> host name?

There is no 1:1 relationship between an OF node and an irq host. (There
is -most- of the time but I left the irq core on purpose more flexible,
hence the match() method. On some setups it makes sense to have multiple
HW PICs share a single domain number (for example on cell).

Thus I'd rather have a way for the host to give you that name, which in
turn can be the OF path if there is such a thing, or something else...

Best might be 4 columns:

<virq> <hwirq> <pic name> <host name>

(PIC name is the same as in /proc/interrupts).
 
> Do you prefer debugfs instead of /proc/interrupts?

Yes, at least for now. Maybe if we can convince ourselves that nothing
significant would break of changing /proc/interrupts, then we can add
stuffs to it, but I'd rather avoid.

Ben.

  reply	other threads:[~2007-03-13 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13  3:19 [PATCH] Add irq host and hwirq pair fields to output when showing interrupts Zhang Wei
2007-03-13  7:14 ` Benjamin Herrenschmidt
2007-03-13  9:32   ` [PATCH] Add irq host and hwirq pair fields to output whenshowing interrupts Zhang Wei-r63237
2007-03-13 13:52     ` Benjamin Herrenschmidt [this message]
2007-03-15  9:53       ` [PATCH] Add irq host and hwirq pair fields to outputwhenshowing interrupts Zhang Wei-r63237
2007-03-15 10:22         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173793926.24454.74.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=Haiying.Wang@freescale.com \
    --cc=Wei.Zhang@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).