From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] powerpc: fix suspend states again
Date: Mon, 19 Mar 2007 17:06:05 +0100 [thread overview]
Message-ID: <1174320365.5044.20.camel@localhost.localdomain> (raw)
In-Reply-To: <20070319105358.796834000@sipsolutions.net>
> +
> +int save_processor_state(void)
> +{
> + /* Giveup the lazy FPU & vec so we don't have to back them
> + * up from the low level code
> + */
> + enable_kernel_fp();
> +
> +#ifdef CONFIG_ALTIVEC
> + if (cur_cpu_spec->cpu_features & CPU_FTR_ALTIVEC)
> + enable_kernel_altivec();
> +#endif /* CONFIG_ALTIVEC */
> +
> + return 0;
> +}
You need to check if there's an FPU I suppose for enable_kernel_fp()
since this is generic code potentially used with embedded CPUs as well.
In fact, it would be good to also add some of the freescale stuff.
Ben.
next prev parent reply other threads:[~2007-03-19 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 10:53 [PATCH 0/5] powermac suspend fixes Johannes Berg
2007-03-19 10:53 ` [PATCH 1/5] powerpc: generic time suspend/resume code Johannes Berg
2007-03-19 14:47 ` Benjamin Herrenschmidt
2007-03-19 21:51 ` Guennadi Liakhovetski
2007-03-19 22:11 ` Johannes Berg
2007-03-19 23:21 ` Guennadi Liakhovetski
2007-03-21 20:47 ` David Brownell
2007-03-21 22:48 ` Guennadi Liakhovetski
2007-05-02 5:02 ` Michael Ellerman
2007-05-02 8:25 ` Johannes Berg
2007-05-02 11:06 ` Michael Ellerman
2007-05-02 14:04 ` Johannes Berg
2007-03-19 10:53 ` [PATCH 2/5] powerpc: fix suspend states again Johannes Berg
2007-03-19 14:48 ` Benjamin Herrenschmidt
2007-03-19 15:22 ` Johannes Berg
2007-03-19 15:32 ` Benjamin Herrenschmidt
2007-03-19 15:45 ` Johannes Berg
2007-03-19 15:54 ` Johannes Berg
2007-03-19 16:22 ` Johannes Berg
2007-03-19 16:39 ` Benjamin Herrenschmidt
2007-03-19 16:06 ` Benjamin Herrenschmidt [this message]
2007-03-19 10:53 ` [PATCH 3/5] powermac: disallow pmu sleep notifiers from aborting sleep Johannes Berg
2007-03-19 14:49 ` Benjamin Herrenschmidt
2007-03-19 10:53 ` [PATCH 4/5] powermac: proper sleep management Johannes Berg
2007-03-19 14:50 ` Benjamin Herrenschmidt
2007-03-19 15:16 ` Johannes Berg
2007-03-19 23:44 ` Johannes Berg
2007-03-20 0:11 ` [PATCH 4/5 v2] " Johannes Berg
2007-03-20 0:48 ` Johannes Berg
2007-03-20 2:19 ` Johannes Berg
2007-03-19 10:53 ` [PATCH 5/5] remove dead code in via-pmu68k Johannes Berg
2007-03-19 19:17 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174320365.5044.20.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).