From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean-Christophe Dubois <jdubois@mc.com>
Cc: linuxppc-dev@ozlabs.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] powerpc: fix dcr_unmap()
Date: Wed, 28 Mar 2007 22:42:56 +1000 [thread overview]
Message-ID: <1175085776.32220.9.camel@localhost.localdomain> (raw)
In-Reply-To: <200703281207.41425.jdubois@mc.com>
On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> Fix a bug in dcr_unmap().
>
> At unmap time the DCR offset need to be added instead of substracted.
>
> Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
If possible that should go in 2.6.21
> Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
> ===================================================================
> --- linux-2.6.20.orig/arch/powerpc/sysdev/dcr.c
> +++ linux-2.6.20/arch/powerpc/sysdev/dcr.c
> @@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
>
> if (h.token == NULL)
> return;
> - h.token -= dcr_n * h.stride;
> + h.token += dcr_n * h.stride;
> iounmap(h.token);
> h.token = NULL;
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2007-03-28 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 10:07 [PATCH] powerpc: fix dcr_unmap() Jean-Christophe Dubois
2007-03-28 12:42 ` Benjamin Herrenschmidt [this message]
2007-03-28 20:55 ` Linus Torvalds
2007-03-28 22:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175085776.32220.9.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=jdubois@mc.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).