[PATCH] powerpc: fix dcr_unmap()

[PATCH] powerpc: fix dcr_unmap()

[Jean-Christophe Dubois]

Fix a bug in dcr_unmap(). 

At unmap time the DCR offset need to be added instead of substracted.

Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>

Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
===================================================================
--- linux-2.6.20.orig/arch/powerpc/sysdev/dcr.c
+++ linux-2.6.20/arch/powerpc/sysdev/dcr.c
@@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
 
 	if (h.token == NULL)
 		return;
-	h.token -= dcr_n * h.stride;
+	h.token += dcr_n * h.stride;
 	iounmap(h.token);
 	h.token = NULL;
 }

Re: [PATCH] powerpc: fix dcr_unmap()

[Benjamin Herrenschmidt]

On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> Fix a bug in dcr_unmap(). 
> 
> At unmap time the DCR offset need to be added instead of substracted.
> 
> Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

If possible that should go in 2.6.21

> Index: linux-2.6.20/arch/powerpc/sysdev/dcr.c
> ===================================================================
> --- linux-2.6.20.orig/arch/powerpc/sysdev/dcr.c
> +++ linux-2.6.20/arch/powerpc/sysdev/dcr.c
> @@ -129,7 +129,7 @@ void dcr_unmap(dcr_host_t host, unsigned
>  
>  	if (h.token == NULL)
>  		return;
> -	h.token -= dcr_n * h.stride;
> +	h.token += dcr_n * h.stride;
>  	iounmap(h.token);
>  	h.token = NULL;
>  }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: fix dcr_unmap()

[Linus Torvalds]

On Wed, 28 Mar 2007, Benjamin Herrenschmidt wrote:

> On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> > Fix a bug in dcr_unmap(). 
> > 
> > At unmap time the DCR offset need to be added instead of substracted.
> > 
> > Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
> 
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> 
> If possible that should go in 2.6.21

Can I get an original patch email and/or a git pull request? I didn't see 
the original email, since I'm not on the linuxppc list..

		Linus

Re: [PATCH] powerpc: fix dcr_unmap()

[Benjamin Herrenschmidt]

On Wed, 2007-03-28 at 13:55 -0700, Linus Torvalds wrote:
> 
> On Wed, 28 Mar 2007, Benjamin Herrenschmidt wrote:
> 
> > On Wed, 2007-03-28 at 11:07 +0100, Jean-Christophe Dubois wrote:
> > > Fix a bug in dcr_unmap(). 
> > > 
> > > At unmap time the DCR offset need to be added instead of substracted.
> > > 
> > > Signed-off-by: Jean-Christophe Dubois <jdubois@mc.com>
> > 
> > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > 
> > If possible that should go in 2.6.21
> 
> Can I get an original patch email and/or a git pull request? I didn't see 
> the original email, since I'm not on the linuxppc list..

Sorry about that, I'll bounce it to you