From: David Woodhouse <dwmw2@infradead.org>
To: cbe-oss-dev@ozlabs.org
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] Implement check_legacy_ioport() on PS3
Date: Fri, 30 Mar 2007 01:02:52 +0100 [thread overview]
Message-ID: <1175212972.3122.87.camel@pmac.infradead.org> (raw)
It doesn't like it when we poke at legacy I/O ports like the i8042. We
should probably change the _default_ to return -ENODEV, and let any
strange platform which wants to allow unfettered access provide its own
function for that.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
--- linux-2.6.20.ppc64/arch/powerpc/platforms/ps3/setup.c.orig 2007-03-30 00:45:59.000000000 +0100
+++ linux-2.6.20.ppc64/arch/powerpc/platforms/ps3/setup.c 2007-03-30 00:48:29.000000000 +0100
@@ -230,6 +230,11 @@ static void ps3_machine_kexec(struct kim
}
#endif
+static int ps3_check_legacy_ioport(unsigned int baseport)
+{
+ return -ENODEV;
+}
+
define_machine(ps3) {
.name = "PS3",
.probe = ps3_probe,
@@ -240,6 +245,7 @@ define_machine(ps3) {
.set_rtc_time = ps3_set_rtc_time,
.get_rtc_time = ps3_get_rtc_time,
.calibrate_decr = ps3_calibrate_decr,
+ .check_legacy_ioport = ps3_check_legacy_ioport,
.progress = ps3_progress,
.restart = ps3_restart,
.power_off = ps3_power_off,
--
dwmw2
next reply other threads:[~2007-03-30 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 0:02 David Woodhouse [this message]
2007-03-30 1:45 ` [PATCH] Implement check_legacy_ioport() on PS3 Olof Johansson
2007-03-30 1:43 ` David Woodhouse
2007-03-30 1:43 ` [Cbe-oss-dev] " Michael Ellerman
2007-03-30 1:47 ` Benjamin Herrenschmidt
2007-03-30 1:49 ` David Woodhouse
2007-03-30 1:45 ` Benjamin Herrenschmidt
2007-03-30 13:44 ` Segher Boessenkool
2007-04-06 21:32 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175212972.3122.87.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).