From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] cbe_cpufreq.c initialisation
Date: Tue, 03 Apr 2007 18:37:31 +1000 [thread overview]
Message-ID: <1175589451.30879.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20070403182037.93221d65.sfr@canb.auug.org.au>
On Tue, 2007-04-03 at 18:20 +1000, Stephen Rothwell wrote:
> Hi all,
>
> In cbe_cpufreq_cpu_init, there is this code:
>
> max_freq = (u32*) get_property(cpu, "clock-frequency", NULL);
> // we need the freq in kHz
> *max_freq /= 1000;
>
> does this really need to modify the property value in place?
No, that's obviously a bug...
Ben.
next prev parent reply other threads:[~2007-04-03 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 8:20 cbe_cpufreq.c initialisation Stephen Rothwell
2007-04-03 8:37 ` Benjamin Herrenschmidt [this message]
2007-04-03 8:44 ` [Cbe-oss-dev] " Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175589451.30879.14.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox