From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1E4CDDDECB for ; Wed, 4 Apr 2007 08:59:23 +1000 (EST) Subject: Re: [PATCH] Stop pmac_zilog from abusing 8250's device numbers. From: David Woodhouse To: Brad Boyer In-Reply-To: <20070403203735.GB12332@cynthia.pants.nu> References: <1175610345.2665.15.camel@shinybook.infradead.org> <20070403203735.GB12332@cynthia.pants.nu> Content-Type: text/plain Date: Tue, 03 Apr 2007 18:58:39 -0400 Message-Id: <1175641120.10567.15.camel@shinybook.infradead.org> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2007-04-03 at 13:37 -0700, Brad Boyer wrote: > Shouldn't we have defines for these? It doesn't seem good to have more > magic numbers floating around in the code. I wondered about that, but decided against it. They're only used in one place, and it's obvious what they are and where they come from. It's not as if '#define PMAC_ZILOG_MAJOR 204' and '.major = PMAC_ZILOG_MAJOR' would actually make it any clearer. Quite the opposite, in fact, since 204 is used for other things too. -- dwmw2