From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org
Subject: Re: adding Pegasus IDE quirk for pata_via
Date: Thu, 05 Apr 2007 09:52:18 +1000 [thread overview]
Message-ID: <1175730738.30879.103.camel@localhost.localdomain> (raw)
In-Reply-To: <20070404111635.GA1855@aepfle.de>
On Wed, 2007-04-04 at 13:16 +0200, Olaf Hering wrote:
> The pegaos board needs an irq quirk in pata_via.
> Where is the quirk list for libata? I dont see one in pata_via.c
>
> drivers/ide/pci/via82cxxx.c:init_hwif_via82cxxx()
>
> 440 #ifdef CONFIG_PPC_CHRP
> 441 if(machine_is(chrp) && _chrp_type == _CHRP_Pegasos) {
> 442 hwif->irq = hwif->channel ? 15 : 14;
> 443 }
> 444 #endif
>
>
> This is in the firmware node. Will a fixup of the 'interrupts' property
> work or does everything poke directly at the PCI registers?
> Should fixup_device_tree_chrp() take care of the 'interrupts' property?
Nothing standard will work. A PCI device isn't supposed to have more
than one interrupt per function and this one needs 2. It's the VIA
chipset being out of specs as usual.
Ben.
next prev parent reply other threads:[~2007-04-04 23:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 11:16 adding Pegasus IDE quirk for pata_via Olaf Hering
2007-04-04 16:20 ` [PATCH] add correct interrupt property for pegasos ide Olaf Hering
2007-04-04 18:10 ` Bartlomiej Zolnierkiewicz
2007-04-04 18:11 ` Olaf Hering
2007-04-04 18:42 ` Bartlomiej Zolnierkiewicz
2007-04-05 1:47 ` Benjamin Herrenschmidt
2007-04-05 10:32 ` Olaf Hering
2007-04-05 1:46 ` Benjamin Herrenschmidt
2007-04-05 0:55 ` Stephen Rothwell
2007-04-04 23:52 ` Benjamin Herrenschmidt [this message]
2007-04-09 13:13 ` adding Pegasus IDE quirk for pata_via Matt Sealey
2007-04-09 14:40 ` Alan Cox
2007-04-09 17:39 ` Matt Sealey
2007-04-10 16:22 ` Olaf Hering
2007-08-16 17:01 ` Olaf Hering
2007-08-16 17:00 ` Olaf Hering
2007-08-17 13:10 ` [PATCH] advertise correct IDE mode on Pegasos2 Olaf Hering
2007-08-17 14:33 ` Olaf Hering
2007-08-17 18:19 ` Matt Sealey
2007-08-17 18:30 ` Olaf Hering
2007-08-17 18:27 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175730738.30879.103.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).