From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] hvc_console polling mode timer backoff
Date: Thu, 12 Apr 2007 11:14:36 -0500 [thread overview]
Message-ID: <1176394477.28514.32.camel@farscape.rchland.ibm.com> (raw)
Add a backoff mechanism to hvc_console's polling logic. This change
drops the timers/second ratio from ~90 to ~1 while the console is idle.
This is very noticable when watching /proc/timer_stats output.
This only affects when the hvc_console is running in poll mode, i.e. power4
and cell systems.
I've tested on Power4, Michael Ellerman has tested on cell.
Signed-off-by: Will Schmidt <will_schmidt@vnet.ibm.com>
cc: Michael Ellerman <michael@ellerman.id.au>
---
drivers/char/hvc_console.c | 31 +++++++++++++++++++++++++------
1 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
index a0a88aa..8ac8066 100644
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -47,8 +47,6 @@ #include "hvc_console.h"
#define HVC_MAJOR 229
#define HVC_MINOR 0
-#define TIMEOUT (10)
-
/*
* Wait this long per iteration while trying to push buffered data to the
* hypervisor before allowing the tty to complete a close operation.
@@ -550,6 +548,19 @@ static int hvc_chars_in_buffer(struct tt
return hp->n_outbuf;
}
+/*
+ * timeout will vary between the MIN and MAX values defined here. By default
+ * and during console activity we will use a default MIN_TIMEOUT of 10. When
+ * the console is idle, we increase the timeout value on each pass through
+ * msleep until we reach the max. This may be noticeable as a brief (average
+ * one second) delay on the console before the console responds to input when
+ * there has been no input for some time.
+ */
+#define MIN_TIMEOUT (10)
+#define MAX_TIMEOUT (2000)
+static u32 timeout = MIN_TIMEOUT;
+
+
#define HVC_POLL_READ 0x00000001
#define HVC_POLL_WRITE 0x00000002
@@ -642,9 +653,14 @@ #endif /* CONFIG_MAGIC_SYSRQ */
bail:
spin_unlock_irqrestore(&hp->lock, flags);
- if (read_total)
+ if (read_total) {
+ /* Activity is occurring, so reset the polling backoff value to
+ a minimum for performance. */
+ timeout = MIN_TIMEOUT;
+
tty_flip_buffer_push(tty);
-
+ }
+
return poll_mask;
}
@@ -688,8 +704,11 @@ int khvcd(void *unused)
if (!hvc_kicked) {
if (poll_mask == 0)
schedule();
- else
- msleep_interruptible(TIMEOUT);
+ else {
+ if (timeout < MAX_TIMEOUT)
+ timeout++;
+ msleep_interruptible(timeout);
+ }
}
__set_current_state(TASK_RUNNING);
} while (!kthread_should_stop());
next reply other threads:[~2007-04-12 16:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 16:14 Will Schmidt [this message]
2007-04-12 16:17 ` [PATCH] hvc_console typo corrections Will Schmidt
2007-04-12 17:33 ` [PATCH] hvc_console polling mode timer backoff Linas Vepstas
2007-04-12 18:43 ` Will Schmidt
2007-04-12 19:09 ` Olof Johansson
2007-04-13 0:45 ` Michael Ellerman
2007-04-13 1:56 ` Olof Johansson
2007-04-13 7:47 ` Michael Ellerman
2007-04-13 16:46 ` Linas Vepstas
2007-04-13 19:11 ` Will Schmidt
2007-04-15 13:33 ` Michael Ellerman
2007-04-16 19:34 ` Will Schmidt
2007-04-14 19:42 ` Milton Miller
2007-04-16 17:03 ` Linas Vepstas
2007-04-16 20:22 ` Will Schmidt
2007-04-16 21:59 ` Linas Vepstas
2007-04-17 0:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176394477.28514.32.camel@farscape.rchland.ibm.com \
--to=will_schmidt@vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).