From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: Fix PowerPC 750CL CPU features
Date: Thu, 12 Apr 2007 12:11:46 -0500 [thread overview]
Message-ID: <1176397906.6379.77.camel@zod.rchland.ibm.com> (raw)
In-Reply-To: <2830816F-F1C5-450C-BA68-287D8C312561@kernel.crashing.org>
On Thu, 2007-04-12 at 12:06 -0500, Kumar Gala wrote:
> On Apr 12, 2007, at 11:41 AM, Segher Boessenkool wrote:
>
> >> PowerPC 750CL has high BATs. The patch below sets cpu_features to
> >> match that.
> >> Without it, the original firmware mappings in the high BATs aren't
> >> cleared
> >> which can cause "odd" address translations to occur.
> >
> >> - .cpu_features = CPU_FTRS_750,
> >> + .cpu_features = CPU_FTRS_750GX,
> >
> > The difference between these two is
> >
> > #define CPU_FTRS_750GX (CPU_FTR_DUAL_PLL_750FX |
> > CPU_FTR_HAS_HIGH_BATS)
> > #define CPU_FTRS_750 (CPU_FTR_COMMON)
> >
> > 750GX excludes COMMON, which seems like a bug. With
> > your change, 750CL uses DUAL_PLL_750FX; does it actually
> > have that feature?
>
> I agree the 750GX should include COMMON, we probably don't notice
> since its never in a SMP system.
I'll send a separate patch to fix that.
josh
next prev parent reply other threads:[~2007-04-12 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 12:49 [PATCH] powerpc: Fix PowerPC 750CL CPU features Josh Boyer
2007-04-12 13:49 ` Milton Miller
2007-04-12 13:53 ` Josh Boyer
2007-04-12 16:41 ` Segher Boessenkool
2007-04-12 17:06 ` Kumar Gala
2007-04-12 17:11 ` Josh Boyer [this message]
2007-04-12 17:10 ` Josh Boyer
2007-04-12 19:24 ` Segher Boessenkool
2007-04-13 2:28 ` Benjamin Herrenschmidt
2007-04-13 10:52 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176397906.6379.77.camel@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).