LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: <cbe-oss-dev@ozlabs.org>, <linuxppc-dev@ozlabs.org>
Subject: [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable
Date: Fri, 13 Apr 2007 11:48:58 +1000	[thread overview]
Message-ID: <1176428938.598660.69304866740.qpush@pokey> (raw)

spu_reacquire_runnable has an overly-complex way of calculating its
return value. This change fixes it.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

 arch/powerpc/platforms/cell/spufs/run.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
===================================================================
--- linux-2.6-spufs.orig/arch/powerpc/platforms/cell/spufs/run.c
+++ linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
@@ -200,9 +200,7 @@ static inline int spu_reacquire_runnable
 		       SPU_STATUS_STOPPED_BY_HALT)) {
 		return *status;
 	}
-	if ((ret = spu_run_init(ctx, npc)) != 0)
-		return ret;
-	return 0;
+	return spu_run_init(ctx, npc);
 }
 
 /*

             reply	other threads:[~2007-04-13  1:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-13  1:48 Jeremy Kerr [this message]
2007-04-13  7:06 ` [Cbe-oss-dev] [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1176428938.598660.69304866740.qpush@pokey \
    --to=jk@ozlabs.org \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox